Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/swift 5 #217

Merged
merged 6 commits into from Apr 1, 2019

Conversation

Projects
None yet
3 participants
@DanielStormApps
Copy link

commented Mar 27, 2019

Summary

  • Update for Swift 5 and Xcode 10.2 support

Notes

@kean

This comment has been minimized.

Copy link
Owner

commented Mar 27, 2019

Thanks you, @DanielStormApps! I reviewed your changes and made a couple of comments.

Also .travis.yml needs an update.

Daniel Storm
Update `CacheKey` and `LoadKey` `hash(into:)` behavior. Add Swift ver…
…sion check to `sha1` `String` extension. Update `.travis.yml`.
@DanielStormApps

This comment has been minimized.

Copy link
Author

commented Mar 28, 2019

Thanks you, @DanielStormApps! I reviewed your changes and made a couple of comments.

Also .travis.yml needs an update.

Updated. Not sure if I applied the changes you had intended. Seems the builds are failing except for 10.2 environments.

@kean

This comment has been minimized.

Copy link
Owner

commented Mar 28, 2019

Thank you for addressing the comments. I will review and merge this on the weekend. If there are any remaining issues, I'm will address them. Thanks again, @DanielStormApps!

@kean kean merged commit e18b4df into kean:master Apr 1, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kean

This comment has been minimized.

Copy link
Owner

commented Apr 1, 2019

@DanielStormApps merged this plus merged the changes to remove per-platform targets. So now instead of Nuke iOS, Nuke macOS, etc targets we have a single target. No duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.