Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift PM: Add tools version to enable Xcode build #219

Merged
merged 1 commit into from Apr 7, 2019

Conversation

Projects
None yet
2 participants
@shpakovski
Copy link
Contributor

commented Apr 3, 2019

Hi Alexander, it looks like your master branch is ready for tools v5. Proposed changes make a package working on Mac. Thanks!

@kean

This comment has been minimized.

Copy link
Owner

commented Apr 6, 2019

Hi, @shpakovski! This looks good, have you already tested this new package description? Is it possible to keep support for 4.2 packages? I'm not sure anyone is using it though.

@shpakovski

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

This looks good, have you already tested this new package description?

Sure, I use exactly this Package.swift in my project.

Is it possible to keep support for 4.2 packages?

Could you please explain why this matters? We’re two months away from Xcode 11, and your codebase is totally future-proof. This library is more ready for production than competition, I suggest to keep it this way and “force-push” customers to use Swift 5.

I'm not sure anyone is using it though.

Do you mean the older version of Swift or the Swift PM itself, sorry?

@kean kean merged commit b86d2f3 into kean:master Apr 7, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@kean

This comment has been minimized.

Copy link
Owner

commented Apr 7, 2019

Alright, I think it's safe to assume that people who are ahead of the curve and are already using SwiftPM have also already migrated to Swift 5 as well. If there is someone who can't migrate just yet, they can keep using the previous version of Nuke.

Do you mean the older version of Swift or the Swift PM itself, sorry?

Sorry, I wasn't clear enough, I meant SwiftPM.

I'm merging this PR, thanks for putting it together!

@shpakovski

This comment has been minimized.

Copy link
Contributor Author

commented Apr 7, 2019

I can delete own fork now, thanks!

@shpakovski shpakovski deleted the NativeConnect:swift-5 branch Apr 8, 2019

@kean kean modified the milestone: 7.6.1 Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.