test for null byte #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfejfar
commented
Oct 5, 2018
tomasfejfar
commented
Oct 5, 2018
| @@ -55,6 +56,18 @@ public function testConnection(): void | |||
| $this->db->query('SELECT GETDATE() AS CurrentDateTime')->execute(); | |||
| } | |||
|
|
|||
| private function stripNulls(string $fileName): void | |||
| { | |||
| $process = new Process(sprintf('sed -e \'s/,\x00,/,,/\' -i %s', $fileName)); | |||
There was a problem hiding this comment.
I would not trust myself with escaping, which is why I would use argument array
// traditional string based commands
$builder = new Process('ls -lsa');
// same example but using an array
$builder = new Process(array('ls', '-lsa'));
// the array can contain any number of arguments and options
$builder = new Process(array('ls', '-l', '-s', '-a'));
There was a problem hiding this comment.
Also definitely needs a comment to explain what it does and why
| @@ -55,6 +56,18 @@ public function testConnection(): void | |||
| $this->db->query('SELECT GETDATE() AS CurrentDateTime')->execute(); | |||
| } | |||
|
|
|||
| private function stripNulls(string $fileName): void | |||
There was a problem hiding this comment.
stripNullBytesInEmptyFields
There was a problem hiding this comment.
ideally move outside the class and test it in isolation
tomasfejfar
commented
Oct 5, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.