From 3c8130caff7c8acfbb041e99468e10424fdd0c9d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Fejfar?= Date: Tue, 25 Dec 2018 16:54:45 +0100 Subject: [PATCH 1/5] Run travis on 7.3 --- .travis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d03f2dce..ef87edc0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,8 +3,9 @@ sudo: false language: php php: - - 7.1 + - 7.3 - 7.2 + - 7.1 - nightly env: From d95f86e770aa84649db15c8fd7a75d6c41104363 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Fejfar?= Date: Tue, 25 Dec 2018 17:04:21 +0100 Subject: [PATCH 2/5] Local docker from latest PHP 7 --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 5be4c7c4..193d3443 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM php:7.1-cli +FROM php:7-cli ENV COMPOSER_ALLOW_SUPERUSER 1 From 94cd4d199793b3035cc2d641f5d066c7d6366057 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Fejfar?= Date: Tue, 25 Dec 2018 17:05:30 +0100 Subject: [PATCH 3/5] Update CS --- composer.json | 2 +- src/BaseComponent.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 4d53f52f..80aee3b7 100644 --- a/composer.json +++ b/composer.json @@ -40,7 +40,7 @@ "keboola/php-temp": "^1.0", "phpstan/phpstan-shim": "^0.9.1", "phpunit/phpunit": "^7.1", - "keboola/coding-standard": "^4.0" + "keboola/coding-standard": "^7.0.2" }, "scripts": { "tests": "phpunit", diff --git a/src/BaseComponent.php b/src/BaseComponent.php index c996bc89..771d0f17 100644 --- a/src/BaseComponent.php +++ b/src/BaseComponent.php @@ -150,7 +150,7 @@ public function getManifestManager(): ManifestManager return $this->manifestManager; } - public function getLogger() : LoggerInterface + public function getLogger(): LoggerInterface { return $this->logger; } From dfb25b3a8af9416d310ba25ed19461a8fc3ba3c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Fejfar?= Date: Tue, 25 Dec 2018 17:05:49 +0100 Subject: [PATCH 4/5] Fix notice from phpunit --- phpunit.xml.dist | 1 - 1 file changed, 1 deletion(-) diff --git a/phpunit.xml.dist b/phpunit.xml.dist index 088f8ee3..2f731d06 100644 --- a/phpunit.xml.dist +++ b/phpunit.xml.dist @@ -7,7 +7,6 @@ convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" - syntaxCheck="false" bootstrap="tests/bootstrap.php"> tests/ From c71bd2a810afc32357d022345bc9d5e44427dadf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Fejfar?= Date: Fri, 28 Dec 2018 15:38:55 +0100 Subject: [PATCH 5/5] Update config to fixed version, along with other symfony components --- composer.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/composer.json b/composer.json index 80aee3b7..fbc5c4b2 100644 --- a/composer.json +++ b/composer.json @@ -29,10 +29,10 @@ "php": "^7.1", "ext-json": "*", "monolog/monolog": "^1.23", - "symfony/config": "^4.0", - "symfony/filesystem": "^4.0", - "symfony/finder": "^4.0", - "symfony/serializer": "^4.0" + "symfony/config": "^4.2", + "symfony/filesystem": "^4.2", + "symfony/finder": "^4.2", + "symfony/serializer": "^4.2" }, "require-dev": { "devedge/sami-github": "^1.0",