Skip to content

Fix typos #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typos #68

wants to merge 1 commit into from

Conversation

@pgrimaud
Copy link
Contributor

@pgrimaud pgrimaud commented Apr 25, 2020

Hello,

This PR will fix :

  • 2 typos in src/BaseComponent.php
  • 1 typo in src/Config/BaseConfig.php

Cheers! 🤖

@tomasfejfar
Copy link
Contributor

tomasfejfar commented Apr 27, 2020

@ondrajodas any idea why the checks are not ready yet?

@tomasfejfar tomasfejfar requested a review from ondrajodas April 29, 2020 21:46
@ondrajodas ondrajodas mentioned this pull request Apr 30, 2020
Merged
@ondrajodas
Copy link
Contributor

ondrajodas commented Apr 30, 2020

Merged in related PR. I'm closing

@ondrajodas ondrajodas closed this Apr 30, 2020
@tomasfejfar
Copy link
Contributor

tomasfejfar commented Apr 30, 2020

@pgrimaud thanks a lot for your effort and this PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasfejfar tomasfejfar tomasfejfar approved these changes

@ondrajodas ondrajodas Awaiting requested review from ondrajodas

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pgrimaud @tomasfejfar @ondrajodas