Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update csv and temp libs #1

Merged
merged 1 commit into from Oct 26, 2020
Merged

Update csv and temp libs #1

merged 1 commit into from Oct 26, 2020

Conversation

michaljurecko
Copy link
Collaborator

@michaljurecko michaljurecko commented Oct 26, 2020

@michaljurecko michaljurecko force-pushed the webrouse-COM-487 branch 4 times, most recently from 2f858e8 to f67f7e8 Compare October 26, 2020 09:13
Copy link
Collaborator Author

@michaljurecko michaljurecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tato kniznica php-csvtable pridava ku CsvWriter dalsie informacie, ktore patria do manifestu: primaryKey, ...

Pre cosmos-db extractor potrebujem php-csvmap, ktora ma tuto kniznicu ako zavislost.

Stare balicky teda musim aktualizovat.

matrix:
allow_failures:
- php: hhvm
- 7.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nainstalovane kniznice podporuju uz iba PHP 7.1+, ... hhvm uz nepodporuje PHP.

"keboola/csv": "~1.1.0"
"php": "^7.1",
"keboola/php-temp": "^2.0",
"keboola/csv": "^2.2"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potreboval som hlavne aktualizovat php-temp a csv aby som mohol tuto kniznicu pouzit v extractore.

},
"require-dev": {
"phpunit/phpunit": "^5.2",
"phpunit/phpunit": ">=7.5",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verzial 7.5 posledna podporuje PHP 7.1.

use Keboola\Temp\Temp;

/**
* CsvFile class with attribute, primaryKey, incremental and name properties
*/
class Table extends CsvFile {
class Table extends CsvWriter {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V csv:1.0 bola trieda CsvFile ... v csv:2.0 je osobitne CsvWriter a CsvReader.

src/Keboola/CsvTable/Table.php Show resolved Hide resolved
src/Keboola/CsvTable/Table.php Show resolved Hide resolved
* @param array $attributes
*/
public function setAttributes(array $attributes)
public function getHeader(): array
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rovnako po aktualizacii chybala aj getHeader metoda.

@michaljurecko michaljurecko marked this pull request as ready for review October 26, 2020 09:45
@michaljurecko
Copy link
Collaborator Author

@ondrajodas pozries sa na to prosim? blokuje mi to dalsiu pracu

Copy link

@ondrajodas ondrajodas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@michaljurecko michaljurecko merged commit 73df423 into master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants