Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add magefiles #56

Closed
wants to merge 65 commits into from
Closed

Add magefiles #56

wants to merge 65 commits into from

Conversation

khaosdoctor
Copy link
Contributor

@khaosdoctor khaosdoctor commented Feb 9, 2021 •
edited

Adds magefiles to replace makefiles

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)
  • A PR is opened to update the documentation on our docs repo

Fixes #42

khaosdoctor and others added 30 commits February 1, 2021 18:38
@khaosdoctor
Remove unused spec
02863cd 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove comments
6d086a5 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Set status types
0c62a74 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@arschles @khaosdoctor
Creating 2 interceptor services (#16)
a89e73f 
* logging

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Adding helm delete functionality to makefile

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Splitting up functionality, logs and more

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* checking error fetching services

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Using the proper service name

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* enabling RBAC on endpoints so the scaler can access interceptor queue sizes

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* logs and TODOs

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* using IPs instead of hostnames in external scaler

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* backing off polling interval

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* logging on external scaler startup

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* removing superfluous logging in scaler

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* port and updating namespaces

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* the right namespace

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* adding grpc reflection

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Makefile targets for creating/deleting example HTTPScaledObject

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Removing namespace from example HTTPScaledObject file

it is specified when you add it from the make target

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* adding keda creation logic to Makefile (and install doc)

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* helm delete keda target

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>

* Passing queue pinger around as a pointer

Otherwise the queue lengths are always reported as 0

Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Created condition provider
32c946b 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Created condition types
8431ef4 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Fix hardcoded names
e52cd61 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Using new condition provider API
6576302 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Forgot to append to slice
b6f05d6 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'main' into main
322ece1 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove runtime object
bc23980 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Update CRD definitions
3127c75 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Added configmaps
34958bd 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove temporary object
d830706 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Change deleted to terminated
ff68673 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove old files
a86ed2a 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Go FMT
3fdd462 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Update CRD with enums
e3ec719 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Log resource version
841e21f 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Update CRD
d056ea3 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add resource version logging
e5a5985 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove broken make command
43155cf 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add timestamp to condition
fe3c1e3 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove useless unknown condition
d1ed32f 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove unknown condition
f528cff 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Fix typo
974dc58 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Receiving context as parameter
cfaff69 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Rename v1 to metav1
c497355 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove log message and final get
e303334 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'main' of https://github.com/khaosdoctor/http-add-on int…
322a49a 
…o main
@khaosdoctor
Copy link
Contributor Author

Added docs, these are good to go

@arschles
Copy link
Collaborator

Since I already deleted it from here, can we remove those Makefiles and I create a mage binary so we don't need to have mage installed?

@khaosdoctor I'd like to leave the Makefile in completely until we all get comfortable using mage (or the binary). at that point, I'm perfectly fine removing

arschles
arschles requested changes Feb 24, 2021
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor this is great. one request: can we not check in the build binaries? it's inevitable that we'll forget to update the binary when we update the Magefile sometime in the future, and I think it's a fair tradeoff to ask developers to download mage before beginning

docs/contributing.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
magefile.go Outdated Show resolved Hide resolved
operator/scripts/download-controller-gen.sh Outdated Show resolved Hide resolved
@khaosdoctor
Merge branch 'main' into magefiles
3eb4162 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove parenthesis
53498f2 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Use go install to install controller gen
74c8255 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add scripts to run operator-only tasks
2052111 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add child directory scripts on main build binary
e4dd43b 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Recompile main task builder
e1cdaa1 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Update docs
f7c86c6 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Renames command to read "build all"
dbe3940 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Copy link
Contributor Author

@arschles done with the previous review

arschles
arschles requested changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor this looks great except for one more piece - can we not have a ./build binary? Instead, can we ask people to download mage and run mage <command>?

@khaosdoctor
Merge branch 'main' of https://github.com/kedacore/http-add-on
ea643c5 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
[WIP] Add magefiles
039d04d 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Tidy sum and mod
e933cbc 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Fix merge error
f30a8e1 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Fix merge error
3259ed5 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'main' into magefiles
3096428 
Signed-off-by:  Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove build binaries
4a94697 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Remove scripts that are no longer used
35b2697 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Copy link
Contributor Author

khaosdoctor commented Mar 2, 2021 •
edited

@khaosdoctor this looks great except for one more piece - can we not have a ./build binary? Instead, can we ask people to download mage and run mage <command>?

Done on 4a94697

@khaosdoctor
Copy link
Contributor Author

Closing this to try to fix DCO

@khaosdoctor khaosdoctor closed this Mar 2, 2021
This was referenced Mar 2, 2021
Closed
Merged
kingdonb pushed a commit to kingdonb/http-add-on that referenced this pull request Jun 12, 2023
@juozasg
Merge pull request kedacore#56 from kingdon-ci:create-cluster-02
f8e19ed 
add cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

@arschles arschles Awaiting requested review from arschles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve contrib experience with magefiles
2 participants
@khaosdoctor @arschles