Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply semgrep suggestions #3998

Merged
merged 11 commits into from
Jan 2, 2023
Merged

fix: apply semgrep suggestions #3998

merged 11 commits into from
Jan 2, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Dec 9, 2022 •
edited
Loading

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Fix some code alerts generated by semgrep

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #3961

@JorTurFer JorTurFer requested a review from a team as a code owner December 9, 2022 22:56
@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 9, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 10, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 10, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Dec 10, 2022 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer
Copy link
Member Author

LGTM

I have to add a lot of extra changes for the rule [Semgrep found a possible error wrong wrapped](https://github.com/kedacore/keda/security/code-scanning/534). If you agree, I'll merge the PR once I have done them and e2e tests pass

@zroubalik
Copy link
Member

LGTM

I have to add a lot of extra changes for the rule [Semgrep found a possible error wrong wrapped](https://github.com/kedacore/keda/security/code-scanning/534). If you agree, I'll merge the PR once I have done them and e2e tests pass

yeah :)

@JorTurFer
fix: apply semgrep suggestions
da22de1 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix some issues
ac089b2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix some issues
e67dfee 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix: Leaky use of time.After in for-select
be798a5 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add whiteline
cd02d20 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix rebase issues
1b1d128 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
semgrep-app[bot]
semgrep-app bot reviewed Jan 2, 2023
View reviewed changes
pkg/scalers/liiklus_scaler.go Outdated Show resolved Hide resolved
@JorTurFer
fix wrong-wrapped-error rule
ea7dd11 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix casting error
346541d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix wrong-wrapped-error rule
d94e9a0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
.
bb49afe 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix tests
22655d9 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Jan 2, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) January 2, 2023 16:51
@JorTurFer JorTurFer merged commit 27e1517 into kedacore:main Jan 2, 2023
@JorTurFer JorTurFer deleted the semgrep-fixes branch January 2, 2023 18:34
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Jan 9, 2023
@JorTurFer
fix: apply semgrep suggestions (kedacore#3998)
8a337fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semgrep-app semgrep-app semgrep-app left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @zroubalik