-
Notifications
You must be signed in to change notification settings - Fork 995
Closed
Labels
CommunityIssue/PR opened by the open-source communityIssue/PR opened by the open-source communityIssue: Feature RequestNew feature or improvement to existing featureNew feature or improvement to existing feature
Description
Context
In both my company's internal slack and the Kedro slack, I'm frequently seeing a question like:
Getting an error like this, anyone encountered before?
ImportError: cannot import name 'ExcelDataSet' from 'kedro_datasets.pandas'
Which is resolved by changing ExcelDataSet to ExcelDataset.
Feature
I'm wondering if Kedro could provide a custom error message with a hint that since 0.19, Dataset is spelled with lowecase s?
Possible implementation
When dataset definitions from Kedro catalog get parsed to paths of Python objects, do something like:
for dataset in catalog:
if dataset.type.endswith("Set") and dataset.type.startswith("kedro_datasets")
raise ValueError(
"Since Kedro 0.19, Dataset is spelled with lowercase 's'. Got {dataset.type}"
)Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
CommunityIssue/PR opened by the open-source communityIssue/PR opened by the open-source communityIssue: Feature RequestNew feature or improvement to existing featureNew feature or improvement to existing feature
Type
Projects
Status
Done