From 9df7043d50a7b907897a6aa1999948b07a48be2b Mon Sep 17 00:00:00 2001 From: lrcouto Date: Wed, 23 Aug 2023 18:29:31 -0300 Subject: [PATCH 1/5] Change starters to use OmegaConfigLoader Signed-off-by: lrcouto --- .../src/{{ cookiecutter.python_package }}/settings.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py index 86a92b1c80..7eab8af2b8 100644 --- a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py +++ b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py @@ -22,8 +22,8 @@ # CONF_SOURCE = "conf" # Class that manages how configuration is loaded. -# from kedro.config import OmegaConfigLoader -# CONFIG_LOADER_CLASS = OmegaConfigLoader +from kedro.config import OmegaConfigLoader +CONFIG_LOADER_CLASS = OmegaConfigLoader # Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor. # CONFIG_LOADER_ARGS = { # "config_patterns": { From 68025491b17a4d35be84b4eadc04c720fbb69314 Mon Sep 17 00:00:00 2001 From: lrcouto Date: Thu, 24 Aug 2023 12:31:09 -0300 Subject: [PATCH 2/5] Fix linter error Signed-off-by: lrcouto --- .../src/{{ cookiecutter.python_package }}/settings.py | 1 + 1 file changed, 1 insertion(+) diff --git a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py index 7eab8af2b8..200dca8c28 100644 --- a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py +++ b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py @@ -23,6 +23,7 @@ # Class that manages how configuration is loaded. from kedro.config import OmegaConfigLoader + CONFIG_LOADER_CLASS = OmegaConfigLoader # Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor. # CONFIG_LOADER_ARGS = { From 013ab0de01d06abd3c04663277e54debbbd24c14 Mon Sep 17 00:00:00 2001 From: "L. R. Couto" Date: Fri, 25 Aug 2023 12:36:03 -0300 Subject: [PATCH 3/5] Suppress import outside toplevel linting for starters template Signed-off-by: L. R. Couto --- .../src/{{ cookiecutter.python_package }}/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py index 200dca8c28..9275c6a611 100644 --- a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py +++ b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py @@ -22,7 +22,7 @@ # CONF_SOURCE = "conf" # Class that manages how configuration is loaded. -from kedro.config import OmegaConfigLoader +from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel CONFIG_LOADER_CLASS = OmegaConfigLoader # Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor. From 0d03acee852495ebab71e2a0124f113546ae5f89 Mon Sep 17 00:00:00 2001 From: lrcouto Date: Mon, 28 Aug 2023 14:22:58 -0300 Subject: [PATCH 4/5] Fix linter error Signed-off-by: lrcouto --- .../src/{{ cookiecutter.python_package }}/settings.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py index 9275c6a611..882ffca8a4 100644 --- a/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py +++ b/kedro/templates/project/{{ cookiecutter.repo_name }}/src/{{ cookiecutter.python_package }}/settings.py @@ -22,7 +22,7 @@ # CONF_SOURCE = "conf" # Class that manages how configuration is loaded. -from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel +from kedro.config import OmegaConfigLoader # noqa: import-outside-toplevel CONFIG_LOADER_CLASS = OmegaConfigLoader # Keyword arguments to pass to the `CONFIG_LOADER_CLASS` constructor. From dd9b45ca5104d5897a66a50d1af0d170b97e9a1e Mon Sep 17 00:00:00 2001 From: lrcouto Date: Tue, 29 Aug 2023 17:31:35 -0300 Subject: [PATCH 5/5] Add changes to release notes Signed-off-by: lrcouto --- RELEASE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/RELEASE.md b/RELEASE.md index 8361d7e7d6..159bf9c420 100644 --- a/RELEASE.md +++ b/RELEASE.md @@ -15,6 +15,7 @@ * Added support for Python 3.11. This includes tackling challenges like dependency pinning and test adjustments to ensure a smooth experience. Detailed migration tips are provided below for further context. * Added `kedro catalog resolve` CLI command that resolves dataset factories in the catalog with any explicit entries in the project pipeline. * Added support for global variables to `OmegaConfigLoader`. +* Change Kedro starters to use `OmegaConfigLoader`. ## Bug fixes and other changes