Conversion of KeeFox to WebExtensions #1

Closed
luckyrat opened this Issue Mar 26, 2017 · 60 comments

Comments

Projects
None yet
@luckyrat
Contributor

luckyrat commented Mar 26, 2017

Per the Milestones schedule on this repository, the bulk of all efforts until the release of version 2.0 will be on ensuring that we can get something vaguely resembling KeeFox 1.6 to run in Firefox 57+ (and Google Chrome, etc.)

That means re-writing the add-on to use WebExtensions.

I've made a good start by pulling over some code snippets from KeeFox 1.6 and piecing them together in a way that has resulted in the current "pre-alpha" version having the following broadly working:

  • Basic add-on architecture (build, default config, logging to console)
  • Connection from add-on to the existing KeePassRPC plugin version
  • Rendering state of connection on a browser button/icon on the browser toolbar
  • Detection of forms on web pages
  • Sending request to find matching logins and receiving list of logins in the web page

The lists below will be expanded as we delve into more detail and see how the WebExtensions API evolves over the next 6 months. With some luck we might be able to implement some items from the "uncertain" list although it's also likely other features will be added to the two lists.

Functionality we are unable to retain

  • Assisted KeePass installation and configuration (prohibited by WebExtensions)
  • Some customised keyboard shortcut keys (it should be possible for each user to manually re-configure them though)
  • Logging to files (prohibited by WebExtensions)
  • Protecting the KeePassRPC authentication token with the Firefox master password (prohibited by WebExtensions)

Functionality we are unlikely to retain (either too much work or uncertain technical viability)

  • Some customised keyboard shortcut keys (we probably won't migrate the current settings but some keyboard shortcuts that relate to specific web pages can be supported if we have time)
  • Launching KeePass from within Firefox (launching executables is banned although if a user were to install a hypothetical "KeeFox helper" executable we might be able to get something to work but it is unlikely that will exist on most user's systems so this work goes to the bottom of the priority list)
  • Multi-page logins (the code that will deal with filling and saving passwords gets created and destroyed on every page load, making this a technically difficult problem to solve)
  • Some assistive UI (e.g. new user advice, tips, security warnings). Things like "Save/update password?" should be possible in some form but may suffer from reduced usability
  • Usage metrics (this is useful for planning how to improve KeeFox but with limited control over the changes we are making for version 2.0, a reduction in the number of platforms running version 2.0 and a lack of time to analyse and act on the limited data we could collect, it's not worthwhile initially)
  • HTTP Auth/Proxy/Windows Auth dialog box filling and saving (not possible to modify the dialog box, other more-limited approaches could work if we have time though)

Please feel free to comment or ask questions below. I'll try to reply regularly but hope you'll understand that my priority is developing the code rather than answering questions that have already been answered multiple times. If you can help answer anyone else's questions or get involved in other discussion threads that would be great.

@luckyrat luckyrat added this to the 2.0 milestone Mar 26, 2017

@luckyrat luckyrat self-assigned this Mar 26, 2017

@yfdyh000

This comment has been minimized.

Show comment
Hide comment
@yfdyh000

yfdyh000 Mar 26, 2017

Contributor

Logging to files (prohibited by WebExtensions)

Bug 1246236 - Implement local filesystem read/write access. NEW Unassigned

Multi-page logins (the code that will deal with filling and saving passwords gets created and destroyed on every page load, making this a technically difficult problem to solve)

Messaging? https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime

Contributor

yfdyh000 commented Mar 26, 2017

Logging to files (prohibited by WebExtensions)

Bug 1246236 - Implement local filesystem read/write access. NEW Unassigned

Multi-page logins (the code that will deal with filling and saving passwords gets created and destroyed on every page load, making this a technically difficult problem to solve)

Messaging? https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Mar 27, 2017

Contributor

Bug 1246236 - Implement local filesystem read/write access. NEW Unassigned

Cool. Thanks for the pointer. Hopefully they will decide to allow it one day. I'll keep an eye on it but not hold my breath just yet.

Messaging? https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime

Yeah that's a key part of the solution but the difficulty will come in making sure we send the right messages at the right time, taking into account all the usual complexity around dynamic form creation, history stack navigation, iframes and other such fun. I think it'll be much clearer what is required once we have a resilient single-page password saving feature working so I'd want to hold off work on multi-page until that's polished enough for a stable release so we can assess whether to press ahead with this feature later in the year.

Contributor

luckyrat commented Mar 27, 2017

Bug 1246236 - Implement local filesystem read/write access. NEW Unassigned

Cool. Thanks for the pointer. Hopefully they will decide to allow it one day. I'll keep an eye on it but not hold my breath just yet.

Messaging? https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime

Yeah that's a key part of the solution but the difficulty will come in making sure we send the right messages at the right time, taking into account all the usual complexity around dynamic form creation, history stack navigation, iframes and other such fun. I think it'll be much clearer what is required once we have a resilient single-page password saving feature working so I'd want to hold off work on multi-page until that's polished enough for a stable release so we can assess whether to press ahead with this feature later in the year.

@yfdyh000

This comment has been minimized.

Show comment
Hide comment
Contributor

yfdyh000 commented Mar 29, 2017

@TeutonJon78

This comment has been minimized.

Show comment
Hide comment
@TeutonJon78

TeutonJon78 Apr 1, 2017

Mozilla has repeatedly said that if plugin developers need extra APIs to be able to do most of what they were able to do before, they would willing to help write those APIs as part of their own WebExtensions+ implementation (not the right name).

I've read of them not actually being so helpful necessarily, but if there's something you need that WebExtensions currently doesn't provide, it seems like reaching out to them for feasibility of getting it back might help.

Thanks for keeping KeeFox working through this transition.

TeutonJon78 commented Apr 1, 2017

Mozilla has repeatedly said that if plugin developers need extra APIs to be able to do most of what they were able to do before, they would willing to help write those APIs as part of their own WebExtensions+ implementation (not the right name).

I've read of them not actually being so helpful necessarily, but if there's something you need that WebExtensions currently doesn't provide, it seems like reaching out to them for feasibility of getting it back might help.

Thanks for keeping KeeFox working through this transition.

@Timvde

This comment has been minimized.

Show comment
Hide comment
@Timvde

Timvde Apr 9, 2017

You can write your own APIs on Developer Edition and Nightly using WebExtension Experiments. You can then propose them for inclusion in the stable builds.

Timvde commented Apr 9, 2017

You can write your own APIs on Developer Edition and Nightly using WebExtension Experiments. You can then propose them for inclusion in the stable builds.

@MisterY

This comment has been minimized.

Show comment
Hide comment
@MisterY

MisterY Apr 23, 2017

Thanks for the link, @yfdyh000. I see that there is some progress being made there, too. Hence, I might ask the obvious question: wouldn't this be a good opportunity to write the migration utility for KeeFox (if any?) and then join the efforts with PassIFox and create one awesome WebExtensions-compatible KeePass browser plugin?
Also, consider this.
The goal for both extensions is the same, the technology is the same. What would be the point of rewriting and maintaining another plugin version? That way we may just end up with two semi-complete plugins because maintainers don't have much time to work on them.
I just don't like wasted effort in general hence it is probably better to ask this question at this stage, before any serious work has been done.

My request from exactly one year ago: pfn/passifox#480

MisterY commented Apr 23, 2017

Thanks for the link, @yfdyh000. I see that there is some progress being made there, too. Hence, I might ask the obvious question: wouldn't this be a good opportunity to write the migration utility for KeeFox (if any?) and then join the efforts with PassIFox and create one awesome WebExtensions-compatible KeePass browser plugin?
Also, consider this.
The goal for both extensions is the same, the technology is the same. What would be the point of rewriting and maintaining another plugin version? That way we may just end up with two semi-complete plugins because maintainers don't have much time to work on them.
I just don't like wasted effort in general hence it is probably better to ask this question at this stage, before any serious work has been done.

My request from exactly one year ago: pfn/passifox#480

@a-polivanchuk

This comment has been minimized.

Show comment
Hide comment
@a-polivanchuk

a-polivanchuk Apr 26, 2017

Hi,
How do you plan to localize v.2?
As I know Transifex doesn't support .json files.
What about current translations? Would it be possible to transfer it to .json?

Hi,
How do you plan to localize v.2?
As I know Transifex doesn't support .json files.
What about current translations? Would it be possible to transfer it to .json?

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Apr 28, 2017

Contributor

@Timvde: Thanks for the link. They are an option although I really hope it doesn't come to that - so far there aren't any great candidate features for requiring the use of an experiment and I would hope that if I have to rely on them, it will be for relatively minor functionality.

Contributor

luckyrat commented Apr 28, 2017

@Timvde: Thanks for the link. They are an option although I really hope it doesn't come to that - so far there aren't any great candidate features for requiring the use of an experiment and I would hope that if I have to rely on them, it will be for relatively minor functionality.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Apr 28, 2017

Contributor

I see where you're coming from @MisterY but I don't think migrating all of KeeFox's users over to a different user interface paradigm, based on (in my opinion) an inferior communications link with KeePass, is going to be in their best interests. While KeeFox 2.0 will have interface and behaviour changes, they are likely to be significantly less than the differences between KeeFox and passifox/chrome. I may just not be looking in the right place but I also don't see support for non-English speakers in passifox so two thirds of KeeFox users would be left at a significant disadvantage if they were forced to switch in the name of combining development resources.

I would welcome collaboration and/or code sharing with anyone that's interested in further development of chromipass, it's just not a project that I can get passionate about directly contributing to when I have such limited time to focus on the people that prefer to use KeeFox.

Contributor

luckyrat commented Apr 28, 2017

I see where you're coming from @MisterY but I don't think migrating all of KeeFox's users over to a different user interface paradigm, based on (in my opinion) an inferior communications link with KeePass, is going to be in their best interests. While KeeFox 2.0 will have interface and behaviour changes, they are likely to be significantly less than the differences between KeeFox and passifox/chrome. I may just not be looking in the right place but I also don't see support for non-English speakers in passifox so two thirds of KeeFox users would be left at a significant disadvantage if they were forced to switch in the name of combining development resources.

I would welcome collaboration and/or code sharing with anyone that's interested in further development of chromipass, it's just not a project that I can get passionate about directly contributing to when I have such limited time to focus on the people that prefer to use KeeFox.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Apr 28, 2017

Contributor

@a-polivanchuk: I'm not sure yet. Probably someone has worked out how to get Chrome translations into Transifex before though and yes, I'm expecting to write a tool to convert Firefox properties into chrome/webextensions format to ensure that all relevant existing translations can be retained with minimal or no effort from the translators.

Contributor

luckyrat commented Apr 28, 2017

@a-polivanchuk: I'm not sure yet. Probably someone has worked out how to get Chrome translations into Transifex before though and yes, I'm expecting to write a tool to convert Firefox properties into chrome/webextensions format to ensure that all relevant existing translations can be retained with minimal or no effort from the translators.

@borian

This comment has been minimized.

Show comment
Hide comment
@borian

borian May 13, 2017

relating to a possible collaboration, the re-implementation will continue to use the KeePassRPC plugin, instead of KeePassHttp ?

borian commented May 13, 2017

relating to a possible collaboration, the re-implementation will continue to use the KeePassRPC plugin, instead of KeePassHttp ?

@freMea

This comment has been minimized.

Show comment
Hide comment
@freMea

freMea May 27, 2017

And what about KeeWeb support ?

freMea commented May 27, 2017

And what about KeeWeb support ?

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Jun 4, 2017

Contributor

Here's a quick update on the current status of the WebExtensions port.

The code is broadly in the state that I was aiming for at the alpha 1 milestone point but there are a few tasks I've postponed and a few others I've done ahead of schedule.

Because there may still be security flaws lurking in among the partly re-written code, and I don't have time to dedicate to look for them yet, I'm not planning to release a packaged version of the WebExtensions add-on for others to use just yet, although you can of course clone the repo and package it up yourself if you want to try it out with some test databases.

I'm planning to work on site-specific settings next, as well as a proof of concept for the password saving feature planned for a later alpha milestone. I'm also not happy with the way the iframe support works so might re-write that in the coming weeks if I can find a way to do it better.

Regarding translations ( @a-polivanchuk ) I have discovered that Transifex supports the required messages.json files and have also found an existing tool that helped me to convert the en-US strings from the existing format. In a month or two, when I've got a better idea of which strings will still be relevant, I'll do another test to see how easy Transifex is able to make the selection of translations from the existing resource format. If it's going to be a pain, I'll look at spending some time writing further scripts to help with the format migration but I'm optimistic that step won't be required.

Contributor

luckyrat commented Jun 4, 2017

Here's a quick update on the current status of the WebExtensions port.

The code is broadly in the state that I was aiming for at the alpha 1 milestone point but there are a few tasks I've postponed and a few others I've done ahead of schedule.

Because there may still be security flaws lurking in among the partly re-written code, and I don't have time to dedicate to look for them yet, I'm not planning to release a packaged version of the WebExtensions add-on for others to use just yet, although you can of course clone the repo and package it up yourself if you want to try it out with some test databases.

I'm planning to work on site-specific settings next, as well as a proof of concept for the password saving feature planned for a later alpha milestone. I'm also not happy with the way the iframe support works so might re-write that in the coming weeks if I can find a way to do it better.

Regarding translations ( @a-polivanchuk ) I have discovered that Transifex supports the required messages.json files and have also found an existing tool that helped me to convert the en-US strings from the existing format. In a month or two, when I've got a better idea of which strings will still be relevant, I'll do another test to see how easy Transifex is able to make the selection of translations from the existing resource format. If it's going to be a pain, I'll look at spending some time writing further scripts to help with the format migration but I'm optimistic that step won't be required.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Jul 31, 2017

Contributor

These areas have all been improved since my last update:

  • site-specific settings
  • KeePassRPC authentication popup
  • iframe support
  • dynamicly loaded forms
  • password saving support

So that's most of what I wanted to get done in alpha 1, 2 and 3, with some bits from alpha 4.

There are still a variety of parts of the code that I've implemented without a full understanding of the APIs in use and some hacks to work around Firefox limitations which will hopefully be removed before the complete WebExtensions API is released later in the year.

I expect those issues (identifiable by "//TODO:c:" in the code) to be resolved over the coming months and in the mean time I'm going to start testing the alpha release, work on the changes required to the interactive tutorial and enable the start of localisation work.

If anyone wants to help out, I'll gladly accept some PRs with improved styles over the next month at least - I won't have time to focus on prettiness in the foreseeable future and the Firefox default styles appear to be much worse than Chrome so there's a lot to do before an average user can be expected to use this new version.

I've also started putting individual issues on GitHub since we're now past the "re-implement and change all the things" stage; I'll assign myself to any issues that I'm working on so feel free to do the same if you want to have a crack at any of them.

Contributor

luckyrat commented Jul 31, 2017

These areas have all been improved since my last update:

  • site-specific settings
  • KeePassRPC authentication popup
  • iframe support
  • dynamicly loaded forms
  • password saving support

So that's most of what I wanted to get done in alpha 1, 2 and 3, with some bits from alpha 4.

There are still a variety of parts of the code that I've implemented without a full understanding of the APIs in use and some hacks to work around Firefox limitations which will hopefully be removed before the complete WebExtensions API is released later in the year.

I expect those issues (identifiable by "//TODO:c:" in the code) to be resolved over the coming months and in the mean time I'm going to start testing the alpha release, work on the changes required to the interactive tutorial and enable the start of localisation work.

If anyone wants to help out, I'll gladly accept some PRs with improved styles over the next month at least - I won't have time to focus on prettiness in the foreseeable future and the Firefox default styles appear to be much worse than Chrome so there's a lot to do before an average user can be expected to use this new version.

I've also started putting individual issues on GitHub since we're now past the "re-implement and change all the things" stage; I'll assign myself to any issues that I'm working on so feel free to do the same if you want to have a crack at any of them.

@wbedard

This comment has been minimized.

Show comment
Hide comment
@wbedard

wbedard Aug 1, 2017

I was super excited to see the new 2.0 alpha release installed in a fresh profile of Firefox 55 beta 13. I like the way the new app is coming together and really appreciate your time and effort in supporting this project. Keep up the great work!

wbedard commented Aug 1, 2017

I was super excited to see the new 2.0 alpha release installed in a fresh profile of Firefox 55 beta 13. I like the way the new app is coming together and really appreciate your time and effort in supporting this project. Keep up the great work!

@m3Lith

This comment has been minimized.

Show comment
Hide comment
@m3Lith

m3Lith Aug 5, 2017

Regarding translations – when you're working on that, consider taking a look at Crowdin. They seems to support a lot of file types and, at least for me, the translation workflow is more pleasant. They also provide a free plan for OSS projects.

m3Lith commented Aug 5, 2017

Regarding translations – when you're working on that, consider taking a look at Crowdin. They seems to support a lot of file types and, at least for me, the translation workflow is more pleasant. They also provide a free plan for OSS projects.

@nailyk-fr

This comment has been minimized.

Show comment
Hide comment
@nailyk-fr

nailyk-fr Aug 6, 2017

Imho, weblate could be a good option, they support a lot of files type and is open source.
Many thanks for your work!

Imho, weblate could be a good option, they support a lot of files type and is open source.
Many thanks for your work!

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 6, 2017

Contributor

Thanks for the comments everyone.

Regarding translations, I expect to continue using Transifex unless it's unable to meet our needs for some reason. I'm open to trying out other translation platforms if that's the consensus among translators but would prefer to make any change after this migration to WebExtensions has been completed.

Contributor

luckyrat commented Aug 6, 2017

Thanks for the comments everyone.

Regarding translations, I expect to continue using Transifex unless it's unable to meet our needs for some reason. I'm open to trying out other translation platforms if that's the consensus among translators but would prefer to make any change after this migration to WebExtensions has been completed.

@NoXPhasma

This comment has been minimized.

Show comment
Hide comment
@NoXPhasma

NoXPhasma Aug 7, 2017

KeeFox 1.7 stopped working in recent Nightly so I gave your alpha of KeeFox 2 a shot, but unfortunately it reports that KeePass is offline. I guess it's due to the fact that KeePass still has the 1.7 KeePassRPC.plgx file but I wasn't able to find a download for a newer Version.

Do you have a download for a working Plugin with this alpha so I can test it?

KeeFox 1.7 stopped working in recent Nightly so I gave your alpha of KeeFox 2 a shot, but unfortunately it reports that KeePass is offline. I guess it's due to the fact that KeePass still has the 1.7 KeePassRPC.plgx file but I wasn't able to find a download for a newer Version.

Do you have a download for a working Plugin with this alpha so I can test it?

@JadeThaum

This comment has been minimized.

Show comment
Hide comment
@JadeThaum

JadeThaum Aug 8, 2017

I'm in the same boat as NoXPhasma - really love a download if you boys find one.

I'm in the same boat as NoXPhasma - really love a download if you boys find one.

@dlech dlech referenced this issue in kee-org/KeeFox Aug 9, 2017

Closed

Nightly 57.0 breaks KeeFox #801

@gagarine

This comment has been minimized.

Show comment
Hide comment
@gagarine

gagarine Aug 14, 2017

I'm using https://add0n.com/keepass-helper.html during the transition of keefox to webextension. More limited than keefox but at least I can get my user/password without having to quit my browser.

I'm using https://add0n.com/keepass-helper.html during the transition of keefox to webextension. More limited than keefox but at least I can get my user/password without having to quit my browser.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 14, 2017

Contributor

Do you have a download for a working Plugin with this alpha so I can test it?

1.7.0 should work. It's not been tested by me in any Firefox build newer than 2 weeks ago though so I'd be totally unsurprised if it no longer works correctly. I'll try to get a new alpha build done in the next week or two.

Contributor

luckyrat commented Aug 14, 2017

Do you have a download for a working Plugin with this alpha so I can test it?

1.7.0 should work. It's not been tested by me in any Firefox build newer than 2 weeks ago though so I'd be totally unsurprised if it no longer works correctly. I'll try to get a new alpha build done in the next week or two.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 21, 2017

Contributor

I've released https://github.com/kee-org/browser-addon/releases/tag/2.0.0-a4 - I know it doesn't work with HTTP Auth in Firefox but I'll have a fix for that soon. Otherwise, it's not tested and definitely still looks pretty ugly in places. Would be good to get a bug logged in Firefox for the settings inline panel bug since that works fine in Chrome but I might not get around to it for a few weeks.

Contributor

luckyrat commented Aug 21, 2017

I've released https://github.com/kee-org/browser-addon/releases/tag/2.0.0-a4 - I know it doesn't work with HTTP Auth in Firefox but I'll have a fix for that soon. Otherwise, it's not tested and definitely still looks pretty ugly in places. Would be good to get a bug logged in Firefox for the settings inline panel bug since that works fine in Chrome but I might not get around to it for a few weeks.

@NoXPhasma

This comment has been minimized.

Show comment
Hide comment
@NoXPhasma

NoXPhasma Aug 21, 2017

Thanks for the update.

I've installed it and it connects to KeePass. KeePass gives me an authorization code, but Keefox never gives me a prompt to paste it. Even in the settings of Keefox are no options to set the authorization code.

When I look at the "browser-extension-data/keefox@chris.tomlinson/storage.js" in the Firefox Profile folder, I can't find an entry which would be appropriate to add that authorization code. Do I oversee something, or is this just not implemented?

Thanks for the update.

I've installed it and it connects to KeePass. KeePass gives me an authorization code, but Keefox never gives me a prompt to paste it. Even in the settings of Keefox are no options to set the authorization code.

When I look at the "browser-extension-data/keefox@chris.tomlinson/storage.js" in the Firefox Profile folder, I can't find an entry which would be appropriate to add that authorization code. Do I oversee something, or is this just not implemented?

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 28, 2017

Contributor

Alpha 5 is now released: https://github.com/kee-org/browser-addon/releases/tag/2.0.0-a5

When I look at the "browser-extension-data/keefox@chris.tomlinson/storage.js" in the Firefox Profile folder, I can't find an entry which would be appropriate to add that authorization code. Do I oversee something, or is this just not implemented?

The code is never stored. It's used to generate a more secure code that gets put into that file. There's no way to generate that code without Kee and KeePassRPC doing their usual handshake.

Make sure you're not running more than one instance of Kee or KeePass on your computer (even in another user session). If you are, you'd need to configure custom ports.

Contributor

luckyrat commented Aug 28, 2017

Alpha 5 is now released: https://github.com/kee-org/browser-addon/releases/tag/2.0.0-a5

When I look at the "browser-extension-data/keefox@chris.tomlinson/storage.js" in the Firefox Profile folder, I can't find an entry which would be appropriate to add that authorization code. Do I oversee something, or is this just not implemented?

The code is never stored. It's used to generate a more secure code that gets put into that file. There's no way to generate that code without Kee and KeePassRPC doing their usual handshake.

Make sure you're not running more than one instance of Kee or KeePass on your computer (even in another user session). If you are, you'd need to configure custom ports.

@NoXPhasma

This comment has been minimized.

Show comment
Hide comment
@NoXPhasma

NoXPhasma Aug 28, 2017

I do not have multiple sessions of Kee or KeePass running.

With a5 I get endless opened empty authorization Windows of KeePass, when I activate Kee in Firefox or start up Firefox with activated Kee addon. As long as Kee is activated, KeePass will open empty windows every second. I don't know why this is happening, this might be a bug in KeePass?

I'm on Linux and KeePass is version 2.36. Using the default port for RPC (12546).

I do not have multiple sessions of Kee or KeePass running.

With a5 I get endless opened empty authorization Windows of KeePass, when I activate Kee in Firefox or start up Firefox with activated Kee addon. As long as Kee is activated, KeePass will open empty windows every second. I don't know why this is happening, this might be a bug in KeePass?

I'm on Linux and KeePass is version 2.36. Using the default port for RPC (12546).

@dCosminn

This comment has been minimized.

Show comment
Hide comment
@dCosminn

dCosminn Aug 28, 2017

Just got Alpha 5 and seems to work fine here, Windows 10.
I don't like the red/yellow OFF text in the icon, it's too big and distracting. Imo the old icon with the little X was way better.
I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

Just got Alpha 5 and seems to work fine here, Windows 10.
I don't like the red/yellow OFF text in the icon, it's too big and distracting. Imo the old icon with the little X was way better.
I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Aug 29, 2017

@luckyrat In 2.0 alpha release log it's written:

Do not install on a Firefox profile you care about. Once installed, you will be unable to revert to an earlier version of KeeFox.

How to understand this? Does it mean that it won't be possible to co-exist database with earlier KeeFox versions in other Gecko browsers (Pale Moon, Waterfox)? Thanks in advance for a clarification.

Larusek commented Aug 29, 2017

@luckyrat In 2.0 alpha release log it's written:

Do not install on a Firefox profile you care about. Once installed, you will be unable to revert to an earlier version of KeeFox.

How to understand this? Does it mean that it won't be possible to co-exist database with earlier KeeFox versions in other Gecko browsers (Pale Moon, Waterfox)? Thanks in advance for a clarification.

@nailyk-fr

This comment has been minimized.

Show comment
Hide comment
@nailyk-fr

nailyk-fr Aug 29, 2017

How to understand this? Does it mean that it won't be possible to co-exist database with earlier KeeFox versions in other Gecko browsers (Pale Moon, Waterfox)? Thanks in advance for a clarification.

It should mean that your ~/.mozilla/profile cannot be reverted to keefox 1.x
So backup it or use multiples firefox profiles (firefox -ProfileManager)

nailyk-fr commented Aug 29, 2017

How to understand this? Does it mean that it won't be possible to co-exist database with earlier KeeFox versions in other Gecko browsers (Pale Moon, Waterfox)? Thanks in advance for a clarification.

It should mean that your ~/.mozilla/profile cannot be reverted to keefox 1.x
So backup it or use multiples firefox profiles (firefox -ProfileManager)

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Aug 29, 2017

Thanks, that's good. I was afraid that it would somehow make Keepass entries incompatible with 1.x addon. Looking forward for stable release then because Firefox without KeeFox is hardly usable :)

Larusek commented Aug 29, 2017

Thanks, that's good. I was afraid that it would somehow make Keepass entries incompatible with 1.x addon. Looking forward for stable release then because Firefox without KeeFox is hardly usable :)

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 30, 2017

Contributor

I don't like the red/yellow OFF text in the icon, it's too big and distracting. Imo the old icon with the little X was way better.

Thanks for the feedback @dCosminn. Icon guidelines for addons indicate that this new approach is the expected behaviour of an add-on. I think it is technically possible to develop a more complex solution rather than using the built-in APIs but I'm unsure whether it would pass review and would take time that I don't have at the moment but I'll bear this point in mind after version 2 is stable and released in case there's something we can do differently (more like the old behaviour).

I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

There could be a few different interpretations of your feedback here. Please can you explain in a bit more detail what you're trying to do, how it's working now and what you would like it be like?

Contributor

luckyrat commented Aug 30, 2017

I don't like the red/yellow OFF text in the icon, it's too big and distracting. Imo the old icon with the little X was way better.

Thanks for the feedback @dCosminn. Icon guidelines for addons indicate that this new approach is the expected behaviour of an add-on. I think it is technically possible to develop a more complex solution rather than using the built-in APIs but I'm unsure whether it would pass review and would take time that I don't have at the moment but I'll bear this point in mind after version 2 is stable and released in case there's something we can do differently (more like the old behaviour).

I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

There could be a few different interpretations of your feedback here. Please can you explain in a bit more detail what you're trying to do, how it's working now and what you would like it be like?

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Aug 30, 2017

Contributor

With a5 I get endless opened empty authorization Windows of KeePass, when I activate Kee in Firefox or start up Firefox with activated Kee addon. As long as Kee is activated, KeePass will open empty windows every second. I don't know why this is happening, this might be a bug in KeePass?

This is probably the same as #22 so please contribute to that issue.

Contributor

luckyrat commented Aug 30, 2017

With a5 I get endless opened empty authorization Windows of KeePass, when I activate Kee in Firefox or start up Firefox with activated Kee addon. As long as Kee is activated, KeePass will open empty windows every second. I don't know why this is happening, this might be a bug in KeePass?

This is probably the same as #22 so please contribute to that issue.

@dCosminn

This comment has been minimized.

Show comment
Hide comment
@dCosminn

dCosminn Sep 1, 2017

I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

There could be a few different interpretations of your feedback here. Please can you explain in a bit more detail what you're trying to do, how it's working now and what you would like it be like?

I don't have KeePass.exe running all the time so.. the old functionality. Like the option to click on the Kee icon and launch KeePass.exe from there.

A bug i have with alpha 5, if i have the Kee Icon near the overflow icon(>>) it will go into the overflow menu.
Like this is when i have customization On, the Kee icon is in proper place: http://i.imgur.com/Sz902Gl.png
Then when i close the customziation the Kee icon is not there anymore: http://i.imgur.com/venU9IN.png, it goes intro the overflon menu: http://i.imgur.com/Vu1aZyo.png

dCosminn commented Sep 1, 2017

I really miss the option to launch the Keepass from within the browser, it's annoying to use keyboard shortcuts.

There could be a few different interpretations of your feedback here. Please can you explain in a bit more detail what you're trying to do, how it's working now and what you would like it be like?

I don't have KeePass.exe running all the time so.. the old functionality. Like the option to click on the Kee icon and launch KeePass.exe from there.

A bug i have with alpha 5, if i have the Kee Icon near the overflow icon(>>) it will go into the overflow menu.
Like this is when i have customization On, the Kee icon is in proper place: http://i.imgur.com/Sz902Gl.png
Then when i close the customziation the Kee icon is not there anymore: http://i.imgur.com/venU9IN.png, it goes intro the overflon menu: http://i.imgur.com/Vu1aZyo.png

@gagarine

This comment has been minimized.

Show comment
Hide comment
@gagarine

gagarine Sep 2, 2017

A bug i have with alpha 5, if i have the Kee Icon near the overflow icon(>>) it will go into the overflow menu.

I think this is a Firefox problem, check if you have the same behavior with other plugin. I'm pretty sure you simply don't have enough space on the bar (Firefox hide icons if their is not enough space) You can remove the search input to have more space: the location (URL) input has the same functionalities now .

gagarine commented Sep 2, 2017

A bug i have with alpha 5, if i have the Kee Icon near the overflow icon(>>) it will go into the overflow menu.

I think this is a Firefox problem, check if you have the same behavior with other plugin. I'm pretty sure you simply don't have enough space on the bar (Firefox hide icons if their is not enough space) You can remove the search input to have more space: the location (URL) input has the same functionalities now .

@dCosminn

This comment has been minimized.

Show comment
Hide comment
@dCosminn

dCosminn Sep 2, 2017

I tried removing icons and let the ublock near and it didn't "disappear". But yes, i think it was a Nightly issue, after today's update everything seems ok.

dCosminn commented Sep 2, 2017

I tried removing icons and let the ublock near and it didn't "disappear". But yes, i think it was a Nightly issue, after today's update everything seems ok.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Sep 4, 2017

Contributor

I don't have KeePass.exe running all the time so.. the old functionality. Like the option to click on the Kee icon and launch KeePass.exe from there.

Launching applications isn't supported in the new versions of Firefox. It would be possible to implement a new intermediary application that can enable this functionality although it's not a trivial task (and definitely won't be achievable before we launch v2.0). I've created an issue to record the feature request: #23

Contributor

luckyrat commented Sep 4, 2017

I don't have KeePass.exe running all the time so.. the old functionality. Like the option to click on the Kee icon and launch KeePass.exe from there.

Launching applications isn't supported in the new versions of Firefox. It would be possible to implement a new intermediary application that can enable this functionality although it's not a trivial task (and definitely won't be achievable before we launch v2.0). I've created an issue to record the feature request: #23

@guillefar

This comment has been minimized.

Show comment
Hide comment
@guillefar

guillefar Sep 7, 2017

Hi Luckyrat, I wanted to beta test the new addon, I installed along with Firefox 55 (had to force install it), but keefox is not asking me to enter the code Keepass is showing me. Does the alpha version only works with Firefox 57? (I though Firefox 55 could run addons made for both the old and the new engine, perhaps I'm wrong).

Hi Luckyrat, I wanted to beta test the new addon, I installed along with Firefox 55 (had to force install it), but keefox is not asking me to enter the code Keepass is showing me. Does the alpha version only works with Firefox 57? (I though Firefox 55 could run addons made for both the old and the new engine, perhaps I'm wrong).

@nailyk-fr

This comment has been minimized.

Show comment
Hide comment
@nailyk-fr

nailyk-fr Sep 7, 2017

@guillefar

This comment has been minimized.

Show comment
Hide comment
@guillefar

guillefar Sep 7, 2017

So Keefox 2 alpha should work in Firefox 55? Then not sure why I'm not getting the authorization form. Any ideas?

So Keefox 2 alpha should work in Firefox 55? Then not sure why I'm not getting the authorization form. Any ideas?

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Sep 7, 2017

Contributor

I don't expect it to work properly on 55 and will not release it for that version so I've never tested it - sounds like it's completely broken. I think it will work in 56 - I'm not aware of any reason it won't but I've not tested it myself. If it does work, great - we can release with a little overlap for users to upgrade before the release of FF57 but I'm focussed on getting it working well in 57 first.

Contributor

luckyrat commented Sep 7, 2017

I don't expect it to work properly on 55 and will not release it for that version so I've never tested it - sounds like it's completely broken. I think it will work in 56 - I'm not aware of any reason it won't but I've not tested it myself. If it does work, great - we can release with a little overlap for users to upgrade before the release of FF57 but I'm focussed on getting it working well in 57 first.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Sep 11, 2017

Contributor

It does not work in FF56. There is a Firefox bug which prevents Kee from loading its configuration when attempting to establish the connection to KeePassRPC. Unless Mozilla fix https://bugzilla.mozilla.org/show_bug.cgi?id=1398956 we'll have to go for a big bang switch-over of FireFox 56 => 57 and KeeFox 1.7 => Kee 2.0 on the same day which could be pretty messy!

Since this is such a fundamental bug, I've not been able to test any other features of the addon in 56 yet.

Contributor

luckyrat commented Sep 11, 2017

It does not work in FF56. There is a Firefox bug which prevents Kee from loading its configuration when attempting to establish the connection to KeePassRPC. Unless Mozilla fix https://bugzilla.mozilla.org/show_bug.cgi?id=1398956 we'll have to go for a big bang switch-over of FireFox 56 => 57 and KeeFox 1.7 => Kee 2.0 on the same day which could be pretty messy!

Since this is such a fundamental bug, I've not been able to test any other features of the addon in 56 yet.

@cypressious

This comment has been minimized.

Show comment
Hide comment
@cypressious

cypressious Sep 26, 2017

Just updated to alpha6. Ist there a way to disable the big "OFF" badge?

Just updated to alpha6. Ist there a way to disable the big "OFF" badge?

@tgp1994

This comment has been minimized.

Show comment
Hide comment
@tgp1994

tgp1994 Oct 8, 2017

Hi @luckyrat, I'd love to help you test out the new addon. After reading your blog post about Key though, I'm a little bit confused about how I can join the beta program to help. I downloaded KeyPass 1.7.2b1 from the addon store like the blog post suggested, so am I officially helping now? I see on the releases page for this project that we shouldn't install to a profile we care about, although I do care about this profile...

tgp1994 commented Oct 8, 2017

Hi @luckyrat, I'd love to help you test out the new addon. After reading your blog post about Key though, I'm a little bit confused about how I can join the beta program to help. I downloaded KeyPass 1.7.2b1 from the addon store like the blog post suggested, so am I officially helping now? I see on the releases page for this project that we shouldn't install to a profile we care about, although I do care about this profile...

@m3Lith

This comment has been minimized.

Show comment
Hide comment
@m3Lith

m3Lith Oct 9, 2017

@tgp1994 The 1.7.2b1 version isn't a web-extension, so no, "officially" you're not helping.

If you would like to try the new version, as of now you need to manually download the latest alpha (.xpi file) from this repo – check releases. It's pretty stable, but it's still an alpha – thus the warning. Though it seems like we'll have a proper beta soon, possibly this month. So you could wait for that – I believe there's a good chance it will be pushed to AMO as well, replacing 1.7.2b1.

m3Lith commented Oct 9, 2017

@tgp1994 The 1.7.2b1 version isn't a web-extension, so no, "officially" you're not helping.

If you would like to try the new version, as of now you need to manually download the latest alpha (.xpi file) from this repo – check releases. It's pretty stable, but it's still an alpha – thus the warning. Though it seems like we'll have a proper beta soon, possibly this month. So you could wait for that – I believe there's a good chance it will be pushed to AMO as well, replacing 1.7.2b1.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Oct 9, 2017

Contributor

I believe there's a good chance it will be pushed to AMO as well, replacing 1.7.2b1.

Yeah, that's the plan. No idea exactly when though - still trying to work around and establish the scale of various Firefox bugs before pushing it more widely to the beta channel.

Alphas installed from here will never get automatic updates so you should only be installing them if you're following the development of Kee 2.0 closely enough that you'll spot an upgraded version fairly soon after it gets released.

Contributor

luckyrat commented Oct 9, 2017

I believe there's a good chance it will be pushed to AMO as well, replacing 1.7.2b1.

Yeah, that's the plan. No idea exactly when though - still trying to work around and establish the scale of various Firefox bugs before pushing it more widely to the beta channel.

Alphas installed from here will never get automatic updates so you should only be installing them if you're following the development of Kee 2.0 closely enough that you'll spot an upgraded version fairly soon after it gets released.

@seiferflo

This comment has been minimized.

Show comment
Hide comment
@seiferflo

seiferflo Oct 10, 2017

Hi. Sorry to ask this, but is there an alpha version of KeePassRPC (using 1.7.3 at the moment) ?
Currently, even though the latest alpha version of Kee works ok in FF57b, it still says "You are not logged in to your password database".
nb: Kee advanced settings points to the same db folder as KeePass.
Thanks for your feedback !

seiferflo commented Oct 10, 2017

Hi. Sorry to ask this, but is there an alpha version of KeePassRPC (using 1.7.3 at the moment) ?
Currently, even though the latest alpha version of Kee works ok in FF57b, it still says "You are not logged in to your password database".
nb: Kee advanced settings points to the same db folder as KeePass.
Thanks for your feedback !

@nailyk-fr

This comment has been minimized.

Show comment
Hide comment
@nailyk-fr

nailyk-fr Oct 10, 2017

What about an IRC chan on freenode?
This way we can help each other, and maybe help you to the development?

P.S.: I suggest IRC because it is easy to setup gateway for other closed source systems.

What about an IRC chan on freenode?
This way we can help each other, and maybe help you to the development?

P.S.: I suggest IRC because it is easy to setup gateway for other closed source systems.

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Oct 10, 2017

@seiferflo
1.7.3 is latest. I had same problem, it turned out it was ublock blocking pop-up with authorization window. Stop adblocking for installation of Kee.

@luckyrat
Alpha 12 works but it still hangs entire Firefox after some time like in #27 and similar threads.

Larusek commented Oct 10, 2017

@seiferflo
1.7.3 is latest. I had same problem, it turned out it was ublock blocking pop-up with authorization window. Stop adblocking for installation of Kee.

@luckyrat
Alpha 12 works but it still hangs entire Firefox after some time like in #27 and similar threads.

@derritter88

This comment has been minimized.

Show comment
Hide comment
@derritter88

derritter88 Oct 10, 2017

@Larusek have you deactivated Firefox build-in pop-up blocker as well?
I have disabled ublock but there is still not pop-up from Kee to indicate that Kee and Keepass would like to link with each other.

@Larusek have you deactivated Firefox build-in pop-up blocker as well?
I have disabled ublock but there is still not pop-up from Kee to indicate that Kee and Keepass would like to link with each other.

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Oct 10, 2017

No, only ublock did the trick for me. Did you first uninstall Kee addon then disable ublock -> install Kee from scratch? You could try with new/clean Firefox profile, too (for test).

Larusek commented Oct 10, 2017

No, only ublock did the trick for me. Did you first uninstall Kee addon then disable ublock -> install Kee from scratch? You could try with new/clean Firefox profile, too (for test).

@derritter88

This comment has been minimized.

Show comment
Hide comment
@derritter88

derritter88 Oct 10, 2017

Thanks - that was the missing thing! Need to remove Kee completly and reinstall it while ublock was disabled.
Now it works!

Thanks - that was the missing thing! Need to remove Kee completly and reinstall it while ublock was disabled.
Now it works!

@rugk

This comment has been minimized.

Show comment
Hide comment
@rugk

rugk Oct 10, 2017

it turned out it was ublock blocking pop-up with authorization window.

Did you report this issue to ublock?

rugk commented Oct 10, 2017

it turned out it was ublock blocking pop-up with authorization window.

Did you report this issue to ublock?

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Oct 10, 2017

No, I'm not sure by how much my extensive custom rules affect it. Maybe with default install it works OK?

Larusek commented Oct 10, 2017

No, I'm not sure by how much my extensive custom rules affect it. Maybe with default install it works OK?

@derritter88

This comment has been minimized.

Show comment
Hide comment
@derritter88

derritter88 Oct 11, 2017

Is the search function from the Firefox plugin still planned/working?
My plugin just says:
You are logged in to your '' password database
Save latest login
Generate new password
Help Centre
Options

Is the search function from the Firefox plugin still planned/working?
My plugin just says:
You are logged in to your '' password database
Save latest login
Generate new password
Help Centre
Options

@Larusek

This comment has been minimized.

Show comment
Hide comment
@Larusek

Larusek Oct 11, 2017

Same here. And search was very convenient.

Larusek commented Oct 11, 2017

Same here. And search was very convenient.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Oct 12, 2017

Contributor

What about an IRC chan on freenode?

I'm not sure there's much benefit to that over using GitHub issues to have a focussed discussion about each bit of work that needs doing. I've already got this and the KeeFox forums to keep track of so I wouldn't personally be able to commit time to an IRC channel too.

Contributor

luckyrat commented Oct 12, 2017

What about an IRC chan on freenode?

I'm not sure there's much benefit to that over using GitHub issues to have a focussed discussion about each bit of work that needs doing. I've already got this and the KeeFox forums to keep track of so I wouldn't personally be able to commit time to an IRC channel too.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Oct 12, 2017

Contributor

Is the search function from the Firefox plugin still planned/working?

#7

It's pending a clear use case that fits within the new WebExtensions limitations. I won't rule it out being re-implemented one day - definitely not in the next month though.

Contributor

luckyrat commented Oct 12, 2017

Is the search function from the Firefox plugin still planned/working?

#7

It's pending a clear use case that fits within the new WebExtensions limitations. I won't rule it out being re-implemented one day - definitely not in the next month though.

@tgp1994

This comment has been minimized.

Show comment
Hide comment
@tgp1994

tgp1994 Oct 12, 2017

tgp1994 commented Oct 12, 2017

@gagarine

This comment has been minimized.

Show comment
Hide comment
@gagarine

gagarine Oct 14, 2017

@tgp1994 you can open other issue in this repository. In my opinion we should close this one.

@tgp1994 you can open other issue in this repository. In my opinion we should close this one.

@luckyrat

This comment has been minimized.

Show comment
Hide comment
@luckyrat

luckyrat Oct 25, 2017

Contributor

Thanks for all the input on this issue everyone.

Please continue any general discussion about Kee 2.0 on the new community forum: https://forum.kee.pm/

Contributor

luckyrat commented Oct 25, 2017

Thanks for all the input on this issue everyone.

Please continue any general discussion about Kee 2.0 on the new community forum: https://forum.kee.pm/

@luckyrat luckyrat closed this Oct 25, 2017

luckyrat added a commit that referenced this issue Nov 27, 2017

@luckyrat luckyrat added the enhancement label Jan 8, 2018

@luckyrat luckyrat removed their assignment Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment