Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder to Website field #175

Closed
luckyrat opened this issue Apr 9, 2018 · 0 comments
Closed

Add placeholder to Website field #175

luckyrat opened this issue Apr 9, 2018 · 0 comments

Comments

@luckyrat
Copy link
Member

@luckyrat luckyrat commented Apr 9, 2018

In the "specific website" settings mode of the Kee options, it is not obvious what to type to get the best results.

We should apply the same placeholder to the Website field on the main settings page and on the site properties popup (although the latter will only become visible if the user deletes the pre-filled text from the main website field).

We should use text like:

e.g. www.google.com (Do NOT include a protocol like https://)

The HTML localisation script lib/i18n.js needs to be enhanced to understand placeholder attributes before we can implement this but that shouldn't be too hard - we can say that all keys that begin with placeholder_ will be assigned to the placeholder attribute. Let me know if you're interested in working on this and want some help.

@luckyrat luckyrat added this to the 3.1 milestone Mar 1, 2019
@luckyrat luckyrat self-assigned this Apr 1, 2019
@luckyrat luckyrat closed this in 2b609e7 Apr 1, 2019
@luckyrat luckyrat removed their assignment Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.