New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define panels font color as black in panels css. #207

Merged
merged 2 commits into from Nov 17, 2018

Conversation

Projects
None yet
2 participants
@ljoonal
Copy link
Contributor

ljoonal commented Nov 16, 2018

Fixes text visibility for those who have defined their default font color as something bright/white.
This is a huge problem for me, since I can never see what account I'm trying to select.

I asked about this on the forum quite a long time ago, and got no replies ( link ), so I decided to see if I could fix it.

Please tell me if I did something wrong, haven't really contributed that much ^^".

Added a line of css to define font-color as black
If this is not set, and someone uses userCSS for example, and they have their default font-color as white, it wouldn't be recognizable from the background color.
@luckyrat

This comment has been minimized.

Copy link
Member

luckyrat commented Nov 16, 2018

A look for similar situations in other parts of the add-on suggests that you'll be experiencing similar problems in the main menu popup and other areas (e.g. search results, notification boxes in popup.css; network authentication dialog in NetworkAuth.css) but maybe Firefox behaves differently in those parts compared to the in-page panels that you've already highlighted in your forum post?

If necessary, it would be good to apply a similar fix to those areas too so that this can be a "complete" fix for the white text on a white background problem.

@ljoonal

This comment has been minimized.

Copy link
Contributor

ljoonal commented Nov 16, 2018

I tried to find what you're talking about by reinstalling and re-configuring Kee, but I've failed to find anything that would have the same kind of problems. Most pages seem to be themed by bootstrap.min.css, and that seems to include the font-color as #333.

But I did notice that there was still some white text in the panel, like the header text for example. Applying the font-color to body of the panel would ensure that everything has a default color of black.

@luckyrat

This comment has been minimized.

Copy link
Member

luckyrat commented Nov 17, 2018

Ah cool, I forgot / didn't know that Bootstrap would set the colour too. Thanks for looking into it.

This looks good so I'll pull it onto master. I don't think the change quite fits the profile for something that we should try to squeeze into the current v2.4 release cycle so it'll go into v2.5, probably around the start of next year, depending on what other issues crop up in the coming weeks.

@luckyrat luckyrat merged commit bf60bd8 into kee-org:master Nov 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment