Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder type to form fields #18

Closed
wants to merge 1 commit into from

Conversation

@Px7-941
Copy link

commented Dec 20, 2017

add support for the new type to the service and model.
Info: now you can use values like {TOTP} with the placeholder field type.

Fixes: #17, #8, #11
Browser Repo issue: kee-org/browser-addon#49

Add placeholder type to form fields, add support for the new type to …
…the service and model.

Info: now you can use values like {TOTP}
@luckyrat

This comment has been minimized.

Copy link
Member

commented Apr 9, 2018

I'm sorry for the very slow response to this. I'm not sure this is the correct approach for enabling TOTP in Kee so want to work that out first before diving into the specifics of this implementation.

In the mean time, I'm interested whether you performed any performance tests?

For what it's worth, I share the concerns of @chrestomanci in the linked issue although I feel that adding generalised support for placeholders is not worthy of user warning. Such warnings about using KeePass to store 2FA keys should rather be displayed within KeePass itself or whatever plugin enables the use of a "{TOTP}" placeholder.

If such warnings are not present and the plugin authors are not keen to add them, we should consider what additional user eduction would be needed and where and when this could occur. I'd like to shift that discussion back to the community forum though, not least because this may not end up being the PR that we eventually merge into master.

The topic has recently been raised for the first time on the support forum at https://forum.kee.pm/t/kee-and-otp-codes/1037

@luckyrat

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

An alternative approach has been implemented in v1.8: https://github.com/kee-org/keepassrpc/releases/tag/v1.8.0

@luckyrat luckyrat closed this Apr 23, 2018

@Px7-941

This comment has been minimized.

Copy link
Author

commented May 4, 2018

Thank you for the new release. It works perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.