Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating document from node template creates a new document and a new template #1

Open
CesarCapillas opened this issue Sep 23, 2017 · 4 comments

Comments

@CesarCapillas
Copy link

Hi:

I tested this interesting addon and I found a strange behaviour when using it. Maybe you can confirm it.

I understand that this is tracked via cm:templatable aspect, and the addon is extending the "Create from node template" query in Share UI.

When I add cm:templatable aspect to a document in a site, all seem correct. I can see and select a new template node between the node template list. But the problem arises when creating content from this templatable node, because this aspect is also included in the "copy". So creating a document from a template node "creates" a new template, and the list of node templates grows and grows and so on... Did I miss something ?

I use Alfresco Community 201707GA and 1.1 release version of the addon.

Regards.
--C.

angelborroy pushed a commit that referenced this issue Sep 23, 2017
Default cm:templatable is also added to content copied from original
template, so we need a new aspect to identify templates from copies
@angelborroy-ks
Copy link
Contributor

You were right, the addon implementation was wrong.

Solved for 2.0.0 release.

Thanks for your feedback!

@CesarCapillas
Copy link
Author

Hi Angel:

Thanks for your message and commits for 2.0.0 release.
AFAIK these changes will have the same results but working with the new custom aspect instead of the original cm:templatable one. Isn't that the case?

Regards.
--C.

angelborroy pushed a commit that referenced this issue Sep 25, 2017
Attaching behaviour to exclude “site templatable” aspect from copies
@angelborroy-ks
Copy link
Contributor

If I fail to include projected behaviour, then yes.

Last commit should fix that.

@CesarCapillas
Copy link
Author

Now it works fine, as expected!
Thanks Angel.
--C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants