Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Withdraw on KeepBonding should check for zero value transfer #280

Closed
pdyraga opened this issue Mar 4, 2020 · 0 comments · Fixed by #281
Closed

Withdraw on KeepBonding should check for zero value transfer #280

pdyraga opened this issue Mar 4, 2020 · 0 comments · Fixed by #281
Assignees
@nkuba
Labels
⛓chain
Milestone
v0.9.0

Comments

@pdyraga
Copy link
Member

pdyraga commented Mar 4, 2020

Requesting the withdrawal of zero ETH in KeepBonding.withdraw should fail as this would allow the method to succeed, calling the user-provided destination even though the sender has no unbonded value. We should require that the amount to be withdrawn is greater than zero.
@pdyraga pdyraga added this to the v0.10.0 milestone Mar 4, 2020
@nkuba nkuba mentioned this issue Mar 4, 2020
Merged
@pdyraga pdyraga modified the milestones: v0.10.0, v0.9.0 Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nkuba nkuba

Labels
⛓chain
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Check for zero value on withdraw from keep keep-network/keep-ecdsa
2 participants
@pdyraga @nkuba