New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save as default name #119

Closed
wants to merge 19 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@seatedscribe
Copy link

seatedscribe commented Jul 18, 2015

Save-as now comes with a default file name, to avoid user creation of filenames without proper extension.

@@ -62,7 +62,7 @@ QString FileDialog::getSaveFileName(QWidget* parent, const QString& caption, QSt
}
else {
if (dir.isEmpty()) {
dir = config()->get("LastDir").toString();
dir = config()->get("LastDir").toString().append("/NewDatabase.kdbx");

This comment has been minimized.

@debfx

debfx Jul 18, 2015

Member

getSaveFileName() is not just used for kdbx databases.
This belongs to DatabaseTabWidget::saveDatabaseAs()

debfx and others added some commits Jul 19, 2015

Copy the database in TestGui before opening it.
We don't want to create lock files in the source tree.
Explicity hide the tray icon before deleting it.
In some conditions the tray icon stayed visible until the application
was closed.
Tested on Kubuntu 15.04 (KDE Plasma 5.2).

@seatedscribe seatedscribe force-pushed the seatedscribe:master branch from a389489 to 4ff2531 Jul 20, 2015

@seatedscribe seatedscribe reopened this Jul 20, 2015

@debfx

This comment has been minimized.

Copy link
Member

debfx commented Jul 25, 2015

The PR contains a lot of unrelated changes.

I've implemented this in a862f62

@debfx debfx closed this Jul 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment