When adding new custom icons the last new entry is not shown

[mkrei]

When adding a new custum icon in the "Edit entry" menu, the new entry is not shown. Only if a second new entry is added to the icons will the first one show up - but the second will remain hidden.

Expected Behavior

New icon shows up immediately to be used for editing the entry

Current Behavior

New icon remains invisible until a second, different icon is added. Adding the same icon again is not possible, as Keepass says the icon already exists.

Possible Solution

Looks like an array length issue where the last element of the array is not being read.

Steps to Reproduce (for bugs)

1. Open "Edit entry"
2. In "Icon" menu select "use custom icon" and click "add custom icon"
3. Attempt to add a new icon that does not yet exist in the database
4. Keepass reports the icon to be added, but it remains invisible
5. Attempt to add the icon again (will fail with "Entry already exists")
6. Add a second custom icon different from the first at least by filename
7. First custom icon appears in selection area, second remains hidden

Context

Probably just a minor issue, but irritating when attempting to customize the stored keys so as to find the right one during a search also by its icon.

Debug Info

KeePassXC - Version 2.3.3
Revision: 0a155d8

Libraries:

• Qt 5.5.1
• libgcrypt 1.8.1

Operating system: Ubuntu 16.04.4 LTS
CPU architecture: x86_64
Kernel: linux 4.15.0-24-generic

Enabled extensions:

Libraries:

• LIBS

Operating system: Ubuntu 16.04.4 LTS 64-bit
CPU architecture: x64
Kernel: Ubuntu 4.15.0-24.26~16.04.1-generic 4.15.18

Enabled extensions:

• Auto-Type
• Browser Integration
• Legacy Browser Integration (KeePassHTTP)
• SSH Agent
• YubiKey

[droidmonkey]

I cannot reproduce this. Either way, this loading behavior was overhauled recently.

[scul86]

I have the same issue. Occurs with both Add custom icon and Download Favicon

KeePassXC - Version 2.3.3
Revision: 0a155d8

Libraries:
- Qt 5.11.1
- libgcrypt 1.8.3

Operating system: Manjaro Linux
CPU architecture: x86_64
Kernel: linux 4.17.9-1-MANJARO

Enabled extensions:
- Auto-Type
- Browser Integration
- Legacy Browser Integration (KeePassHTTP)
- SSH Agent
- YubiKey

[yvanmoriame]

Same as scul86 for me.

Yvan

KeePassXC - Version 2.3.3
Révision : 0a155d8

Bibliothèques :

• Qt 5.10.1
• libgcrypt 1.8.2

Système d’exploitation : Windows 10 (10.0)
Architecture processeur : x86_64
Noyau : winnt 10.0.16299

Extensions activées :

• Auto-Type
• Browser Integration
• Legacy Browser Integration (KeePassHTTP)
• SSH Agent
• YubiKey

[faxik]

Same here.
KeePassXC - Version 2.3.1
Revision: 2fcaeea

Libraries:

• Qt 5.9.5
• libgcrypt 1.8.1

Operating system: Ubuntu 18.04.1 LTS
CPU architecture: x86_64
Kernel: linux 4.15.0-34-generic

[mkrei]

Unfortunatly I can't verify if it was the actual 'fix' anymore, but at least for me the issue resolved itself after I cleaned up my already stored custom icons a bit. During said clean-up I encountered what seemed to be a double entry. After this was removed everything is working properly again with newly added icons showing up as expected.

[yvanmoriame]

OK with your solution mkrei, after removing 3 "double custom icons" everything is working normally.
How were these duplicates added without error in the past?
With a little over 120 icons, it's hard and it takes time to find these double entries.
A tool that would detect this problem of "double icon" would be welcome.

[droidmonkey]

Duplicate of #2251