Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show / Hide toolbar from KeePassXC Settings #1819

Merged
merged 10 commits into from Jul 3, 2018

Conversation

Projects
None yet
3 participants
@vsvyatski
Copy link
Contributor

vsvyatski commented Apr 6, 2018

Description

I have noticed that KeePassXC 2.3.1 has an empty context menu shown when one right-clicks on the main menu. It has a checkbox inside. If one selects/unselects the checkbox the application's main toolbar is shown/hidden. I believe this functionality is a leftover from the version 2.2.4 that was meant to be removed. In the 2.2.4 the context menu had the caption "Toolbar" and also there was View > Toolbar item in the main menu which is gone in 2.3.1. So I've just removed that context menu.

Motivation and context

  1. I believe that somebody just forgot to remove that context menu during the removal of View > Toolbar.
  2. Because the menu has no caption on it, it doesn't give a user much clue what it does.
  3. At the moment of writing the problem is still not fixed in the develop branch.

How has this been tested?

It is a small UI bug, so it has been tested only manually. Test environment details are below:
KeePassXC - Version 2.3.1-snapshot
Build Type: Snapshot
Revision: ddc4b9b

Libraries:

  • Qt 5.10.1
  • libgcrypt 1.8.2

Operating system: Manjaro Linux
CPU architecture: x86_64
Kernel: linux 4.14.31-1-MANJARO

Enabled extensions:

  • Auto-Type

Screenshots (if appropriate):

Here is how it looked before this PR
empty_menu
BTW, the same thing was on Windows
win_empty_menu
This empty menu is now gone.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Apr 7, 2018

There is an open issue wanting that to move this into the settings page (which I agree with): #1618 (comment)

@vsvyatski

This comment has been minimized.

Copy link
Contributor Author

vsvyatski commented Apr 7, 2018

@droidmonkey As I understand, this PR needs to be "extended" to allow that setting, doesn't it?

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Apr 7, 2018

Yes

@vsvyatski

This comment has been minimized.

Copy link
Contributor Author

vsvyatski commented Apr 9, 2018

@droidmonkey That is done. The UI was implemented exactly the way it was proposed there.

@droidmonkey
Copy link
Member

droidmonkey left a comment

Looks great, one minor change

@@ -841,6 +839,8 @@ void MainWindow::applySettingsChanges()
m_inactivityTimer->deactivate();
}

m_ui->toolBar->setHidden(config()->get("GUI/HideToolbar").toBool());

This comment has been minimized.

Copy link
@droidmonkey

droidmonkey Apr 10, 2018

Member

add a second parameter to the get function of "false" or add it to the default config entries in config.cpp

This comment has been minimized.

Copy link
@vsvyatski

vsvyatski Apr 10, 2018

Author Contributor

Done.

@TheZ3ro

TheZ3ro approved these changes Jul 3, 2018

@TheZ3ro TheZ3ro merged commit dcece14 into keepassxreboot:develop Jul 3, 2018

3 checks passed

CodeFactor No issues found.
Details
TeamCity CI (KeepassXC) TeamCity build finished
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@TheZ3ro

This comment has been minimized.

Copy link
Member

TheZ3ro commented Jul 3, 2018

Thanks @vsvyatski for the contribution! 🎉

@TheZ3ro TheZ3ro added this to the v2.4.0 milestone Jul 3, 2018

@TheZ3ro TheZ3ro changed the title Remove empty context menu from the main menu Show / Hide toolbar from KeePassXC Settings Jul 3, 2018

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.