Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass TOTP with credential data to KeePassXC-Browser #1850

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
4 participants
@varjolintu
Copy link
Member

varjolintu commented Apr 16, 2018

When running Set up TOTP a additional KPH attribute for {TOTP} is created for browser integration if it doesn't already exist.

Motivation and context

Fixes #1652.

How has this been tested?

Manually.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@varjolintu varjolintu requested a review from keepassxreboot/core-developers Apr 16, 2018

@weslly
Copy link
Member

weslly left a comment

Wouldn't be better to just skip the creation of this attribute and allow the extension to get the TOTP without it?

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Apr 16, 2018

I'll give it a try.

@TheZ3ro

This comment has been minimized.

Copy link
Member

TheZ3ro commented Apr 16, 2018

+1 for @weslly proposal

@varjolintu varjolintu force-pushed the varjolintu:create_totp_attribute branch from 2312fd6 to 2110ae4 Apr 27, 2018

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Apr 27, 2018

PR updated and rebased with the simplest possible solution. Related browser PR is keepassxreboot/keepassxc-browser#119 which supports also the old KHP attribute format (for now).

@TheZ3ro
Copy link
Member

TheZ3ro left a comment

I really like this new approach

@varjolintu varjolintu changed the title Create KPH attribute for browser integration Pass TOTP with credential data to KeePassXC-Browser Apr 27, 2018

@weslly

weslly approved these changes Apr 27, 2018

@TheZ3ro TheZ3ro merged commit 5c7aaf5 into keepassxreboot:develop Apr 29, 2018

1 check passed

TeamCity CI (KeepassXC) TeamCity build finished
Details

@varjolintu varjolintu deleted the varjolintu:create_totp_attribute branch Apr 29, 2018

@droidmonkey droidmonkey added this to the v2.4.0 milestone Nov 10, 2018

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.