Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Prevent Klipper from storing secrets in clipboard history #1969
Motivation and context
Klipper adds every item to the clipboard history, unless an additional mime type
How has this been tested?
Types of changes
@phoerious look at the difference between the two commits.
In the old commit:
In the new commit:
IMHO it seems pretty easy to understand from the code
Then you can:
On the next rebase, I will squash those 2 commit into 1 so the revert part will not be present in git history
I've deleted the older branch, created a new one with the same name, added the new changes, did a rebase excluding the old commits and force-push.
It's useless to keep in a branch waiting for a merge old changes that are being reverted the next commit.
So, what are you talking about?
Checkout the branch with your git client, what you see is what gets merged.
Aug 29, 2018
added a commit
this pull request
Mar 19, 2019
Is there any chance that this fix doesn't work for Snap installations?
I ask because, unfortunately, running 2.4.0 installed as a Snap on Kubuntu 18.04, my passwords remain in my clipboard indefinitely (rather than 10 seconds, as expected).
I'm more than happy to file a fresh issue for this, but just wanted to check if (a) there was something I had to do in KDE preferences to allow KPXC to clear the clipboard or (b) this wasn't tested on a Snap install and that could be the issue.
KeePassXC - Version 2.4.0
Operating system: Ubuntu Core 18
@sts10 At least I tested it on a regular install only, not on snap. And it's working with the official 2.4.0 release as well. Are you sure you have the right version of klipper installed that has the counterpart patch to look at the metadata sent by keepassxc and ignore it? That patch (https://phabricator.kde.org/D12539) was merged only around May last year but you seem to be on Kubuntu 18.04, so there's a high chance that it's not present in your OS.