Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Agent: Add support for OpenSSH for Windows #1994

Merged
merged 2 commits into from Dec 25, 2018

Conversation

Projects
None yet
2 participants
@hifi
Copy link
Member

hifi commented May 24, 2018

Add support for the new stock OpenSSH ssh-agent in Windows 10.

Description

A new checkbox "Use OpenSSH for Windows instead of Pageant" was added to SSH Agent settings page and is shown only for Windows builds. It is not checked by default.

The Windows-only ACL hardening caused trouble and a change was needed to allow the agent to do enough poking of the calling process to allow a key in. It doesn't seem to expose KeePassXC to any external harm but I'm no expert on the topic.

Motivation and context

Issue #1984.

How has this been tested?

Manual test runs on Windows. It's basically the exact same ssh-agent as on other platforms so it should be fine.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Sep 26, 2018

@hifi can you please post a test sequence for this? What do I need to install (and how) in order to test this functionality?

@droidmonkey
Copy link
Member

droidmonkey left a comment

Tested and works great!

@droidmonkey droidmonkey force-pushed the hifi:feature/openssh-win32 branch from 91be5ae to 9f288ec Dec 25, 2018

@droidmonkey droidmonkey merged commit c34b006 into keepassxreboot:develop Dec 25, 2018

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey referenced this pull request Jan 21, 2019

Open

SSH Agent #2

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.