Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow 12 hour timeout for lockDatabaseIdle #2173

Merged
merged 1 commit into from Aug 20, 2018

Conversation

Projects
None yet
4 participants
@jsachs
Copy link
Contributor

jsachs commented Aug 1, 2018

Allow users to increase the timeout for lockDatabaseIdle to 12 hours.

Description

Increases the maximum lockDatabaseIdleSpinBox value to 43200 seconds.

See #1331

Motivation and context

We are considering enforcing lockDatabaseIdle for all of our users. If this is the case, we want our users to be able to select a much longer maximum timeout.

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@phoerious phoerious added this to the v2.3.4 milestone Aug 2, 2018

@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Aug 2, 2018

@droidmonkey Should we include this in 2.3.4?

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Aug 2, 2018

Yes that is acceptable

@droidmonkey droidmonkey merged commit 1d71059 into keepassxreboot:develop Aug 20, 2018

3 checks passed

CodeFactor No issues found.
Details
TeamCity CI (KeepassXC) TeamCity build finished
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

droidmonkey added a commit that referenced this pull request Aug 22, 2018

Release 2.3.4
- Show all URL schemes in entry view [#1768]
- Disable merge when database is locked [#1975]
- Fix intermittent crashes with favorite icon downloads [#1980]
- Provide potential crash warning to Qt 5.5.x users [#2211]
- Disable apply button when creating new entry/group to prevent data loss [#2204]
- Allow for 12 hour timeout to lock idle database [#2173]
- Multiple SSH Agent fixes [#1981, #2117]
- Multiple Browser Integration enhancements [#1993, #2003, #2055, #2116, #2159, #2174, #2185]
- Fix browser proxy application not closing properly [#2142]
- Add real names and Patreon supporters to about dialog [#2214]
- Add settings button to toolbar, Donate button, and Report a Bug button to help menu [#2214]
- Enhancements to release-tool to appsign intermediate build products [#2101]

@droidmonkey droidmonkey modified the milestones: v2.3.4, v2.4.0 Aug 23, 2018

@ziras

This comment has been minimized.

Copy link

ziras commented Dec 12, 2018

2.3.4 on macOS 10.14.1 still has the restriction of 9999.

image

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Dec 12, 2018

This was added to 2.4.

@jsachs jsachs deleted the jsachs:patch-1 branch Dec 12, 2018

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.