Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar and tool buttons style. #2357

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@boppybibbles
Copy link
Contributor

boppybibbles commented Oct 5, 2018

Description

  • Add ability to change toolbar state and tool buttons style via application settings widget.
  • Save/restore toolbar state on app start/finish.

Motivation and context

How has this been tested?

Manually.

Screenshots (if appropriate):

image

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Oct 6, 2018

I'll be honest: I'm not a very big fan of such a gigantic vertical toolbar and don't really see the point of it.

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Oct 6, 2018

I think it is hideous as well, but, it could be nice for people who have difficulty seeing or for touch screen.

@boppybibbles

This comment has been minimized.

Copy link
Contributor Author

boppybibbles commented Oct 7, 2018

Toolbar position and buttons style is configurable, default values were not changed. Motivation here is accessibility for those who need it.

@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Oct 20, 2018

What are situations in which this is needed besides personal preference?

@boppybibbles

This comment has been minimized.

Copy link
Contributor Author

boppybibbles commented Oct 28, 2018

What are situations in which this is needed besides personal preference?

As per #2343 particular situation is visual agnosia condition.

@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Oct 28, 2018

You don't need a vertical toolbar for that.

boppybibbles added some commits Oct 5, 2018

Toolbar and tool buttons style.
- Add ability to change toolbar state and tool buttons style via
application settings widget.
- Save/restore toolbar state on app start/finish.
- Resolves #2343.
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Oct 28, 2018

@phoerious the vertical orientation is optional, you can drag it around. Although @boppybibbles I couldn't get the toolbar to attach on the sides in Windows. You also have the option of disabling movement of the toolbar (which is nice).

toolbar

@droidmonkey droidmonkey force-pushed the boppybibbles:develop branch from 2748a06 to e9a3fdf Oct 28, 2018

@boppybibbles

This comment has been minimized.

Copy link
Contributor Author

boppybibbles commented Oct 28, 2018

Although @boppybibbles I couldn't get the toolbar to attach on the sides in Windows.

Try to make main window wider. It won't stick if window is not wide enough.

@droidmonkey droidmonkey merged commit d09ca07 into keepassxreboot:develop Jan 16, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.