Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace deprecated parts of code #2419
Performing a dev build against the latest version of Qt fails because of some deprecated members.
As of Qt 5.10, two functions and one class that were used in the code are deprecated.
In the CSV import utility, the
Motivation and context
I'm running Archlinux, which uses the latest version of Qt (5.11.2), and I wasn't able to compile the project with the
How has this been tested?
Types of changes
droidmonkey left a comment
It's not wrong, just difficult.
My only issue with this is that our CI will only be testing the original code on Linux (ie, the deprecated code) since we test with Qt 5.2. Windows CI will test the new code.
I understand the problem. However, I don't think to have changed the code in a very significant way (apart from the
But if you feel that this is too risky, feel free to reject this PR! :)