Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create command to keepassxc-cli #2540

Merged
merged 10 commits into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@louib
Copy link
Member

louib commented Dec 7, 2018

Rebasing #2352
(credits to @vi-n)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation (non-code change)

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.

@louib louib added the plugin: CLI label Dec 7, 2018

@louib louib added this to the v2.4.0 milestone Dec 7, 2018

@louib louib requested review from phoerious and droidmonkey Dec 7, 2018

@louib

This comment has been minimized.

Copy link
Member Author

louib commented Dec 10, 2018

@phoerious @droidmonkey I updated this PR with the recent changes in the CLI module (Using CLI streams like Utils::STDOUT, using global options like Command::KeyFileOption). I think all that's missing is some unit tests, and maybe the -s option too.

@droidmonkey
Copy link
Member

droidmonkey left a comment

If you can add a quick test that would be great, but I approve the code as is.

@louib louib force-pushed the louib:create_command branch from c9bc57a to 8de41a6 Dec 12, 2018

@louib

This comment has been minimized.

Copy link
Member Author

louib commented Dec 12, 2018

@droidmonkey I added 2 tests, but would like to add 1 more before merging (especially testing the key file creation).

@louib louib force-pushed the louib:create_command branch from 794f1aa to 6cc19d1 Dec 13, 2018

@louib

This comment has been minimized.

Copy link
Member Author

louib commented Dec 13, 2018

@droidmonkey should be good now, added unit tests for -k option. Would you mind doing a quick test run on Windows before merging? Again, not sure why the Windows build is failing (SSH exit-code 1)

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Dec 13, 2018

Ok I'll take a look at some point

@louib louib force-pushed the louib:create_command branch from 6cc19d1 to 9cd8b14 Dec 14, 2018

@louib louib force-pushed the louib:create_command branch from 9cd8b14 to e276a1e Dec 15, 2018

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Dec 20, 2018

Good thing I tested this, the ordering of the composite key creation was backwards. You have to do it as: password, keyfile, yubikey. In the incorrect order, you cannot open the database using the gui application. The new ordering works as expected.

Show resolved Hide resolved src/cli/Create.cpp Outdated

@droidmonkey droidmonkey force-pushed the louib:create_command branch from c7063d3 to 55c5bb0 Dec 20, 2018

@droidmonkey droidmonkey merged commit 8ac9d0a into keepassxreboot:develop Dec 20, 2018

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.