Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native hiding of macOS windows #2583

Merged

Conversation

Projects
None yet
5 participants
@varjolintu
Copy link
Member

varjolintu commented Jan 6, 2019

Extends the #1904. Using QWidget::isHidden() does not return a correct value when KeePassXC is hidden (via Cmd+H) but not minimized. Instead, a native method is used to retrieve this state and to hide the window back to the previous state.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

Fixes #2579.

Testing strategy

Manually.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@varjolintu varjolintu added this to the v2.4.0 milestone Jan 6, 2019

@varjolintu varjolintu requested review from weslly and droidmonkey Jan 6, 2019

@varjolintu varjolintu force-pushed the varjolintu:fix_macos_native_hide branch from 554bcfb to 9dbdf33 Jan 6, 2019

@weslly

weslly approved these changes Jan 6, 2019

@jo-so

This comment has been minimized.

Copy link

jo-so commented Jan 6, 2019

There's a whitespace error in this patch:

.git/rebase-apply/patch:39: trailing whitespace.
            macUtils()->raiseLastActiveWindow();   
warning: 1 line adds whitespace errors.
@droidmonkey
Copy link
Member

droidmonkey left a comment

Fix whitespace and add back newline, good to go

@varjolintu varjolintu force-pushed the varjolintu:fix_macos_native_hide branch from 9dbdf33 to 74be406 Jan 6, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Jan 6, 2019

Fixed.

@droidmonkey droidmonkey merged commit f8c6c9f into keepassxreboot:develop Jan 16, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@varjolintu varjolintu deleted the varjolintu:fix_macos_native_hide branch Jan 16, 2019

@cmcnulty

This comment has been minimized.

Copy link

cmcnulty commented Feb 6, 2019

This doesn't appear to fix the issue for me (as I understand it). When running 2.4.0-beta1 on macOS 10.14, when I attempt to minimize the window to the system-tray the dock icon remains visible. My understanding is that the dock tray item would disappear when the 'Hide window to system tray when minimized' box was checked.

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Feb 6, 2019

@cmcnulty And this works with previous versions?

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Feb 6, 2019

@cmcnulty that is a totally different issue, see #1334

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.