Select group when adding credentials from browser extension #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2019
droidmonkey
requested changes
Jan 23, 2019
varjolintu
force-pushed
the
feature/browser_group_selection
branch
2 times, most recently
from
8d5d880
to
3cb7a8d
Compare
droidmonkey
approved these changes
Jan 25, 2019
weslly
approved these changes
Jan 26, 2019
|
Some more work is needed. See: keepassxreboot/keepassxc-browser#388 |
varjolintu
force-pushed
the
feature/browser_group_selection
branch
from
3cb7a8d
to
5c49e8d
Compare
|
Added |
varjolintu
force-pushed
the
feature/browser_group_selection
branch
from
5c49e8d
to
977de1c
Compare
droidmonkey
requested changes
Jan 27, 2019
varjolintu
force-pushed
the
feature/browser_group_selection
branch
2 times, most recently
from
3bd044e
to
69413d7
Compare
droidmonkey
approved these changes
Jan 29, 2019
droidmonkey
force-pushed
the
feature/browser_group_selection
branch
from
69413d7
to
c8cb0e2
Compare
varjolintu
force-pushed
the
feature/browser_group_selection
branch
3 times, most recently
from
73dd258
to
2ad87a0
Compare
droidmonkey
force-pushed
the
feature/browser_group_selection
branch
from
2ad87a0
to
5705469
Compare
droidmonkey
added a commit
that referenced
this pull request
Mar 19, 2019
- New Database Wizard [#1952] - Advanced Search [#1797] - Automatic update checker [#2648] - KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739] - Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439] - Remove KeePassHttp support [#1752] - CLI: output info to stderr for easier scripting [#2558] - CLI: Add --quiet option [#2507] - CLI: Add create command [#2540] - CLI: Add recursive listing of entries [#2345] - CLI: Fix stdin/stdout encoding on Windows [#2425] - SSH Agent: Support OpenSSH for Windows [#1994] - macOS: TouchID Quick Unlock [#1851] - macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583] - Linux: Prevent Klipper from storing secrets in clipboard [#1969] - Linux: Use polling based file watching for NFS [#2171] - Linux: Enable use of browser plugin in Snap build [#2802] - TOTP QR Code Generator [#1167] - High-DPI Scaling for 4k screens [#2404] - Make keyboard shortcuts more consistent [#2431] - Warn user if deleting referenced entries [#1744] - Allow toolbar to be hidden and repositioned [#1819, #2357] - Increase max allowed database timeout to 12 hours [#2173] - Password generator uses existing password length by default [#2318] - Improve alert message box button labels [#2376] - Show message when a database merge makes no changes [#2551] - Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790] - Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description and Context
Allows KeePassXC to set the group when adding new credentials from KeePassXC-Browser. Groups inside Recycle Bin are ignored.
Related KeePassXC-Browser PR: keepassxreboot/keepassxc-browser#396.
Testing strategy
Tested manually with KeePassXC-Browser. Tests included in TestGroups.
Checklist:
-DWITH_ASAN=ON. [REQUIRED]