Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select group when adding credentials from browser extension #2637

Merged

Conversation

Projects
None yet
3 participants
@varjolintu
Copy link
Member

varjolintu commented Jan 23, 2019

Type of change

  • New feature (non-breaking change which adds functionality)

Description and Context

Allows KeePassXC to set the group when adding new credentials from KeePassXC-Browser. Groups inside Recycle Bin are ignored.

Related KeePassXC-Browser PR: keepassxreboot/keepassxc-browser#396.

Testing strategy

Tested manually with KeePassXC-Browser. Tests included in TestGroups.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • I have added tests to cover my changes.
Show resolved Hide resolved src/browser/BrowserAction.cpp Outdated
Show resolved Hide resolved src/core/Group.cpp Outdated
Show resolved Hide resolved src/browser/BrowserService.cpp Outdated

@varjolintu varjolintu force-pushed the varjolintu:feature/browser_group_selection branch 2 times, most recently from 8d5d880 to 3cb7a8d Jan 24, 2019

@weslly

weslly approved these changes Jan 26, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Jan 27, 2019

Some more work is needed. See: keepassxreboot/keepassxc-browser#388

@varjolintu varjolintu force-pushed the varjolintu:feature/browser_group_selection branch from 3cb7a8d to 5c49e8d Jan 27, 2019

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Jan 27, 2019

Added BrowserService::insideRecycleBin() for ignoring groups inside Recycle Bin.

@varjolintu varjolintu force-pushed the varjolintu:feature/browser_group_selection branch from 5c49e8d to 977de1c Jan 27, 2019

Show resolved Hide resolved src/browser/BrowserService.cpp Outdated

@varjolintu varjolintu force-pushed the varjolintu:feature/browser_group_selection branch 2 times, most recently from 3bd044e to 69413d7 Jan 27, 2019

@droidmonkey droidmonkey force-pushed the varjolintu:feature/browser_group_selection branch from 69413d7 to c8cb0e2 Jan 29, 2019

@varjolintu varjolintu force-pushed the varjolintu:feature/browser_group_selection branch 3 times, most recently from 73dd258 to 2ad87a0 Jan 29, 2019

@droidmonkey droidmonkey force-pushed the varjolintu:feature/browser_group_selection branch from 2ad87a0 to 5705469 Jan 30, 2019

@droidmonkey droidmonkey merged commit 891f67a into keepassxreboot:develop Jan 30, 2019

3 of 4 checks passed

Windows 10 (KeepassXC) TeamCity build failed
Details
CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details

@varjolintu varjolintu deleted the varjolintu:feature/browser_group_selection branch Jan 30, 2019

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.