Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code quality updates for 2.4.0 #2709

Merged
merged 5 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@droidmonkey
Copy link
Member

droidmonkey commented Feb 16, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

General quality of code improvements for 2.4.0. Also addressing a couple of issues:

  • Gracefully close KeePassXC and KeePassXC-Browser when receiving end session notice on Windows
  • Fix #2684 - entry references search the whole group tree instead of its current group on down
  • Fix #2697 and fix #2699

Testing strategy

Used rmlogotest from the Windows 10 Developer Kit which simulates an actual shutdown/logoff sequence.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.

droidmonkey added some commits Feb 5, 2019

Shutdown application when receiving notice
* Listen specifically for WM_QUERYENDSESSION and
WM_ENDSESSION to gracefully shutdown KeePassXC
* Cleanup proxy code and add explicit closure for
shutdown messages

@droidmonkey droidmonkey added this to the v2.4.0 milestone Feb 16, 2019

@droidmonkey droidmonkey requested review from phoerious and varjolintu Feb 16, 2019

Show resolved Hide resolved src/proxy/keepassxc-proxy.cpp
Show resolved Hide resolved src/proxy/keepassxc-proxy.cpp Outdated

@droidmonkey droidmonkey merged commit 0c58799 into release/2.4.0 Feb 18, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey deleted the fix/code-quality branch Feb 18, 2019

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.