Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share indication label in group view #2742

Conversation

Projects
None yet
2 participants
@ckieschnick
Copy link
Contributor

ckieschnick commented Feb 26, 2019

Added a sharing label to DatabaseWidget to indicate shared containers.

Type of change

  • Improved feature (non-breaking change which adds functionality)

Description and Context

To highlight that a group is shared, a label is shown with the synchronization method and the path to synchronize to. Improvement is part of #2657
Added a small comment which may allow next reader to see the connection between DatabaseWidget and SearchWidget using the SignalMultiplexer.

Restrictions

The label is only updated enter/leave of a group. It would be possible to observe the changes of the custom data if needed and wished for.

Testing strategy

Manually tested.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

@droidmonkey droidmonkey self-requested a review Feb 26, 2019

Add share indication label in group view
When viewing a shared group, the sharing state is indicated by a label
similar to the search label.

@droidmonkey droidmonkey added this to the v2.4.0 milestone Mar 7, 2019

Enhanced share banner display
* Banner properly shows on children of shared groups
* When searching, share banner is hidden
* Fixed issue where group/entry information was not updated after change

@droidmonkey droidmonkey force-pushed the hicknhack-software:hotfix/2657-sharing-indication-label branch from b973d22 to 23d395f Mar 7, 2019

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Mar 7, 2019

@ckieschnick I enhanced the banner display. Please let me know if you are good to go with the changes, I think this is ready for merge.

@ckieschnick

This comment has been minimized.

Copy link
Contributor Author

ckieschnick commented Mar 7, 2019

I just scanned the changes. Seems fine to me.

@droidmonkey droidmonkey merged commit ebb87e6 into keepassxreboot:release/2.4.0 Mar 7, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.