Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating new groups with Browser Integration #2790


None yet
2 participants
Copy link

varjolintu commented Mar 14, 2019

With keepassxreboot/keepassxc-browser#396 default group for saving passwords can be specified. Any group name not found in the database will be automatically created when saving new credentials.

Type of change

  • New feature (non-breaking change which adds functionality)

Testing strategy

Manually. The tests will be included later in a separate browser tests PR.


  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

QJsonObject result;
auto group = rootGroup->findGroupByPath(groupName);

This comment has been minimized.

Copy link

droidmonkey Mar 16, 2019


My only issue here is that groupName is from user-input data. We should do some basic sanitization and normalization of slashes. Is there a function in the group edit process that checks the name of a group for disallowed characters?

This comment has been minimized.

Copy link

varjolintu Mar 16, 2019

Author Member

I couldn't find any functions that checks input data, even when creating new groups manually.


This comment has been minimized.

Copy link
Member Author

varjolintu commented Mar 16, 2019

A confirmation dialog added when creating new groups.

Allow creating new groups with Browser Integration
Added a confirmation dialog

@droidmonkey droidmonkey force-pushed the varjolintu:feature/browser_create_new_group branch from f401a7f to 70769ab Mar 17, 2019

@droidmonkey droidmonkey merged commit 14e868d into keepassxreboot:release/2.4.0 Mar 18, 2019

4 checks passed

CodeFactor No issues found.
MacOS (KeepassXC) TeamCity build finished
Ubuntu Linux (KeepassXC) TeamCity build finished
Windows 10 (KeepassXC) TeamCity build finished

@varjolintu varjolintu deleted the varjolintu:feature/browser_create_new_group branch Mar 18, 2019

droidmonkey added a commit that referenced this pull request Mar 19, 2019

Release 2.4.0
- New Database Wizard [#1952]
- Advanced Search [#1797]
- Automatic update checker [#2648]
- KeeShare database synchronization [#2109, #1992, #2738, #2742, #2746, #2739]
- Improve favicon fetching; transition to Duck-Duck-Go [#2795, #2011, #2439]
- Remove KeePassHttp support [#1752]
- CLI: output info to stderr for easier scripting [#2558]
- CLI: Add --quiet option [#2507]
- CLI: Add create command [#2540]
- CLI: Add recursive listing of entries [#2345]
- CLI: Fix stdin/stdout encoding on Windows [#2425]
- SSH Agent: Support OpenSSH for Windows [#1994]
- macOS: TouchID Quick Unlock [#1851]
- macOS: Multiple improvements; include CLI in DMG [#2165, #2331, #2583]
- Linux: Prevent Klipper from storing secrets in clipboard [#1969]
- Linux: Use polling based file watching for NFS [#2171]
- Linux: Enable use of browser plugin in Snap build [#2802]
- TOTP QR Code Generator [#1167]
- High-DPI Scaling for 4k screens [#2404]
- Make keyboard shortcuts more consistent [#2431]
- Warn user if deleting referenced entries [#1744]
- Allow toolbar to be hidden and repositioned [#1819, #2357]
- Increase max allowed database timeout to 12 hours [#2173]
- Password generator uses existing password length by default [#2318]
- Improve alert message box button labels [#2376]
- Show message when a database merge makes no changes [#2551]
- Browser Integration Enhancements [#1497, #2253, #1904, #2232, #1850, #2218, #2391, #2396, #2542, #2622, #2637, #2790]
- Overall Code Improvements [#2316, #2284, #2351, #2402, #2410, #2419, #2422, #2443, #2491, #2506, #2610, #2667, #2709, #2731]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.