Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap: improve cursor theme #2832

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
2 participants
@joshirio
Copy link
Contributor

commented Mar 21, 2019

One issue with Qt snaps is the default cursor theme, which is a fallback theme and quite ugly. I propose the following changes to the snapcraft.yaml file to use the system cursor theme when available. Please see the following thread on the snapcraft forum for more background info and limitations of this: https://forum.snapcraft.io/t/qt-apps-and-gtk-themes-an-investigation-with-partial-success/10513

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

To use the system cursor theme, the snap needs to connect to the appropriate plug (icon theme plug). In addition, a new stage package is required (qt5 style plugins).
Please see screenshots below for the result.

Screenshots

Before:
ugly

After:
fix

Testing strategy

Tested on a few different distros. Please see the forum thread above for details.
It works for example with Ubuntu and elementaryOS. Distros that don't support this will keep using the fallback cursor theme, so for them nothing changes, it has only advantages.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
@droidmonkey

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Given the theming drawbacks on unsupported distros, I do not see the benefit just to correct a mouse cursor. I am going to say NO to this change.

@joshirio

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

With this change there's no drawback, because the default fusion style is still used. Only forcing the QGTKStyle plugin (which is not done here) creates issues when the GTK2 settings are not exposed by the theme and or DE.

So this has only the benefit of using a correct mouse theme when available, if not, nothing changes. Since most users are on Ubuntu, I think this would be a great benefit.

@droidmonkey

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Gotcha

@droidmonkey droidmonkey changed the base branch from master to release/2.4.1 Mar 22, 2019

@droidmonkey droidmonkey self-requested a review Mar 22, 2019

@droidmonkey droidmonkey added this to the v2.4.1 milestone Mar 22, 2019

@droidmonkey droidmonkey merged commit 76913a5 into keepassxreboot:release/2.4.1 Mar 22, 2019

3 checks passed

MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@droidmonkey

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

This will be available on the edge channel in about 20 minutes

@joshirio joshirio deleted the joshirio:patch-1 branch Mar 22, 2019

droidmonkey added a commit that referenced this pull request Apr 12, 2019

Release 2.4.1
- Fix database deletion when using unsafe saves to a different file system [#2889]
- Fix opening databases with legacy key files that contain '/' [#2872]
- Fix opening database files from the command line [#2919]
- Fix crash when editing master key [#2836]
- Fix multiple issues with apply button behavior [#2947]
- Fix issues on application startup (tab order, --pw-stdin, etc.) [#2830]
- Fix building without WITH_XC_KEESHARE
- Fix reference entry coloring on macOS dark mode [#2984]
- Hide window when performing entry auto-type on macOS [#2969]
- Improve UX of update checker; reduce checks to every 7 days [#2968]
- KeeShare improvements [#2946, #2978, #2824]
- Re-enable Ctrl+C to copy password from search box [#2947]
- Add KeePassXC-Browser integration for Brave browser [#2933]
- SSH Agent: Re-Add keys on database unlock [#2982]
- SSH Agent: Only remove keys on app exit if they are removed on lock [#2985]
- CLI: Add --no-password option [#2708]
- CLI: Improve database extraction to XML [#2698]
- CLI: Don't call mandb on build [#2774]
- CLI: Add debug info [#2714]
- Improve support for Snap theming [#2832]
- Add support for building on Haiku OS [#2859]
- Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous
- Fix compiling on GCC 5 / Xenial [#2990]
- Add .gitrev output to tarball for third-party builds [#2970]
- Add WITH_XC_UPDATECHECK compile flag to toggle the update checker [#2968]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.