Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide window when performing entry auto-type on macOS #2969

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@droidmonkey
Copy link
Member

commented Apr 10, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Instead of choosing the last active window, always hide the current window (ie, KeePassXC)
  • Fixes #2883

Testing strategy

Tested on macOS

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
@phoerious
Copy link
Member

left a comment

Looks okay to me, but you need to have a look at the tests.

@droidmonkey droidmonkey force-pushed the hotfix/macos-autotype branch from 4da3e9a to d82eaa0 Apr 10, 2019

@droidmonkey

This comment has been minimized.

Copy link
Member Author

commented Apr 10, 2019

Whoops, missed the actual function call.

Hide window when performing entry auto-type on macOS
* Instead of choosing the last active window, always hide the current window (ie, KeePassXC)
* Fixes #2883

@droidmonkey droidmonkey force-pushed the hotfix/macos-autotype branch from d82eaa0 to 17a13e3 Apr 11, 2019

@droidmonkey droidmonkey merged commit 53a57ee into release/2.4.1 Apr 11, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey deleted the hotfix/macos-autotype branch Apr 11, 2019

droidmonkey added a commit that referenced this pull request Apr 12, 2019

Release 2.4.1
- Fix database deletion when using unsafe saves to a different file system [#2889]
- Fix opening databases with legacy key files that contain '/' [#2872]
- Fix opening database files from the command line [#2919]
- Fix crash when editing master key [#2836]
- Fix multiple issues with apply button behavior [#2947]
- Fix issues on application startup (tab order, --pw-stdin, etc.) [#2830]
- Fix building without WITH_XC_KEESHARE
- Fix reference entry coloring on macOS dark mode [#2984]
- Hide window when performing entry auto-type on macOS [#2969]
- Improve UX of update checker; reduce checks to every 7 days [#2968]
- KeeShare improvements [#2946, #2978, #2824]
- Re-enable Ctrl+C to copy password from search box [#2947]
- Add KeePassXC-Browser integration for Brave browser [#2933]
- SSH Agent: Re-Add keys on database unlock [#2982]
- SSH Agent: Only remove keys on app exit if they are removed on lock [#2985]
- CLI: Add --no-password option [#2708]
- CLI: Improve database extraction to XML [#2698]
- CLI: Don't call mandb on build [#2774]
- CLI: Add debug info [#2714]
- Improve support for Snap theming [#2832]
- Add support for building on Haiku OS [#2859]
- Ctrl+PgDn now goes to the next tab and Ctrl+PgUp to the previous
- Fix compiling on GCC 5 / Xenial [#2990]
- Add .gitrev output to tarball for third-party builds [#2970]
- Add WITH_XC_UPDATECHECK compile flag to toggle the update checker [#2968]
@easimon

This comment has been minimized.

Copy link

commented Apr 15, 2019

Seems like this change breaks Auto-Typing in the "Tunnelblick: Login Required" dialog.

Instead of selecting Tunnelblick login dialog, it seems to select the last window that is also reachable with CMD-Tab, and happily pastes login data there.

Unfortunately Tunnelblick is not reachable like this, since it seems to use a different window / dialog type. Even the Tunnelblick configuration window does not have a title bar. Also, Tunnelblick's dialog title is not selectable in the Autotype/Window Associations configuration page in KeepassXC.

It may be arguable if that is an issue in either KeepassXC or Tunnelblick (not providing a main window to change to). But I wonder if that could be solved in KeepassXC again, since it worked before 2.4.1.

@droidmonkey

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

That is unfortunate. Switching to the last selected window is the behavior on every other platform (fwiw). I would argue that Tunnelblick needs to conform to OS window standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.