Add option to prefer DuckDuckGo #2996
Type of change
Description and Context
Some systems provide a favicon.ico out-of-box and set the correct icon via source code. Keepassxc will load the out-of-box icon and not a recognizable/brand icon. Only fix is by hand, because DuckDuckGo is only a fallback.
(I tried to open an issue, but it got declined. Now i wrote a patch and fixed all icons in my kdbx.)
Build works, test run, format only changes not related lines.
@droidmonkey also a nice way. DuckDuckGo supports multiple definitions of favicons and should return the correct one. Only small disadvantage is the possible cache (Quote: Updates to favicons should occur automatically over a period of a few weeks.). As fallback (e.g. local network) is direct download.
Other idea was a second button to force the second way, but that would complicate the UI or load both and select in popover (like advanced page into) has the same problem.