Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create default browser group #3127


3 participants
Copy link

commented May 7, 2019

Default browser password group is not created if the group is set to something else.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

Fixes #3119.
A possible fix to the extension side is also needed because if Root group has not groups, the default group will be still generated.

Testing strategy



  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

louib approved these changes May 7, 2019

Copy link

left a comment

I was looking at this code and had the following thoughts:

  1. For a custom group request, we try to find the group by UUID, then we compare the found group by the passed name. I don't know why that even matters at this point, the UUID is all that matters.
  2. If the custom group is not found in this stage the entry is silently discarded. We should create the custom group similar to the default group if it is not found.
  3. The function name "findCreateAddEntryGroup" is ridiculous. Recommend changing to "getDefaultEntryGroup" and remove the "TODO" that is in that function.

@varjolintu varjolintu force-pushed the varjolintu:hotfix/dont_create_default_browser_group branch from 149f8d0 to 598bdff May 8, 2019


This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

@droidmonkey I agree with the changes. And those are now made.

@droidmonkey droidmonkey merged commit 7ce6f9d into keepassxreboot:release/2.4.2 May 19, 2019

3 checks passed

MacOS (KeepassXC) TeamCity build finished
Ubuntu Linux (KeepassXC) TeamCity build finished
Windows 10 (KeepassXC) TeamCity build finished

@varjolintu varjolintu deleted the varjolintu:hotfix/dont_create_default_browser_group branch May 20, 2019

droidmonkey added a commit that referenced this pull request May 31, 2019

Release 2.4.2
- Improve resilience against memory attacks - overwrite memory before free [#3020]
- Prevent infinite save loop when location is unavailable [#3026]
- Attempt to fix quitting application when shutdown or logout issued [#3199]
- Support merging database custom data [#3002]
- Fix opening URL's with non-http schemes [#3153]
- Fix data loss due to not reading all database attachments if duplicates exist [#3180]
- Fix entry context menu disabling when using keyboard navigation [#3199]
- Fix behaviors when canceling an entry edit [#3199]
- Fix processing of tray icon click and doubleclick [#3112]
- Update group in preview widget when focused [#3199]
- Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996]
- Remove apply button in application settings [#3019]
- Use winqtdeploy on Windows to correct deployment issues [#3025]
- Don't mark entry edit as modified when attribute selection changes [#3041]
- Use console code page CP_UTF8 on Windows if supported [#3050]
- Snap: Fix locking database with session lock [#3046]
- Snap: Fix theming across Linux distributions [#3057]
- Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131]
- KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088]
- macOS: Fix toolbar text when in dark mode [#2998]
- macOS: Lock database on switching user [#3097]
- macOS: Fix global Auto-Type when the database is locked [#3138]
- Browser: Close popups when database is locked [#3093]
- Browser: Add tests [#3016]
- Browser: Don't create default group if custom group is enabled [#3127]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.