Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening url's with non-http schemes #3153

Merged
merged 1 commit into from May 19, 2019

Conversation

2 participants
@SohamG
Copy link
Contributor

commented May 17, 2019

Let the OS handle how to open the url.
Changed the openUrl() function to use a QUrl object, which has the appropriate scheme set.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Fixes #2427
Fixes #2395

Testing strategy

Manually tested with ssh:// and https:// URLs on Linux

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]

Signed-off-by: sohamg sohamg2@gmail.com

Show resolved Hide resolved src/gui/DatabaseWidget.cpp Outdated

@droidmonkey droidmonkey changed the title Fixes #2427 Fix opening url's with non-http[s] schemes May 17, 2019

@SohamG

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Fixed the if block ^^

I don't know if QUrl sets the scheme by default, I have no prior experience in Qt and the docs didn't mention that. I'll test if QUrl does this by default and update accordingly

@SohamG

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

QUrl does indeed do this by default, thanks for the tip. Updated code accordingly.

@SohamG

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2019

@droidmonkey Are any more changes required?

@droidmonkey

This comment has been minimized.

Copy link
Member

commented May 18, 2019

Yes, I am working on this now

@SohamG

This comment has been minimized.

Copy link
Contributor Author

commented May 18, 2019

Thanks, keep me posted

Fix opening url's with non-http schema
* Fix #2427
* Changed the openUrl() function to use a QUrl object, which has the appropriate scheme set.
* Preview widget now passes url handling back to DatabaseWidget

@droidmonkey droidmonkey force-pushed the SohamG:hotfix/2427 branch from d12e69d to 33978d3 May 18, 2019

@droidmonkey droidmonkey added the bug label May 18, 2019

@droidmonkey droidmonkey added this to the v2.4.2 milestone May 18, 2019

@droidmonkey droidmonkey changed the base branch from develop to release/2.4.2 May 18, 2019

@droidmonkey droidmonkey changed the title Fix opening url's with non-http[s] schemes Fix opening url's with non-http schemes May 18, 2019

@droidmonkey

This comment has been minimized.

Copy link
Member

commented May 18, 2019

OK this is ready to go, once CI completes I'll merge. I added the fix for the entry preview panel as well.

@droidmonkey droidmonkey merged commit ecaa4fd into keepassxreboot:release/2.4.2 May 19, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@droidmonkey droidmonkey referenced this pull request May 19, 2019

Closed

URL-Scheme-Override #928

droidmonkey added a commit that referenced this pull request May 31, 2019

Release 2.4.2
- Improve resilience against memory attacks - overwrite memory before free [#3020]
- Prevent infinite save loop when location is unavailable [#3026]
- Attempt to fix quitting application when shutdown or logout issued [#3199]
- Support merging database custom data [#3002]
- Fix opening URL's with non-http schemes [#3153]
- Fix data loss due to not reading all database attachments if duplicates exist [#3180]
- Fix entry context menu disabling when using keyboard navigation [#3199]
- Fix behaviors when canceling an entry edit [#3199]
- Fix processing of tray icon click and doubleclick [#3112]
- Update group in preview widget when focused [#3199]
- Prefer DuckDuckGo service over direct icon download (increases resolution) [#2996]
- Remove apply button in application settings [#3019]
- Use winqtdeploy on Windows to correct deployment issues [#3025]
- Don't mark entry edit as modified when attribute selection changes [#3041]
- Use console code page CP_UTF8 on Windows if supported [#3050]
- Snap: Fix locking database with session lock [#3046]
- Snap: Fix theming across Linux distributions [#3057]
- Snap: Use SNAP_USER_COMMON and SNAP_USER_DATA directories [#3131]
- KeeShare: Automatically enable WITH_XC_KEESHARE_SECURE if quazip is found [#3088]
- macOS: Fix toolbar text when in dark mode [#2998]
- macOS: Lock database on switching user [#3097]
- macOS: Fix global Auto-Type when the database is locked [#3138]
- Browser: Close popups when database is locked [#3093]
- Browser: Add tests [#3016]
- Browser: Don't create default group if custom group is enabled [#3127]

@Niko-CZ Niko-CZ referenced this pull request Jun 4, 2019

Open

custom URL issues #3219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.