Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining issues with menu keyboard navigation #3248

Merged
merged 2 commits into from Jun 11, 2019

Conversation

2 participants
@droidmonkey
Copy link
Member

commented Jun 9, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Entry menu now locks focus on entry when used from menubar
  • When using keyboard navigation to select menubar menus, do not lose focus on selected entry
  • Fixes #3246
  • When the search text edit has focus, retain selected entry keyboard shortcuts and button pressing capability
  • Fixes #3034

Testing strategy

Tested manually and with existing unit tests

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
Fix remaining issues with menu keyboard navigation
* Entry menu now locks focus on entry when used from menubar
* When using keyboard navigation to select menubar menus, do not lose focus on selected entry
* Fixes #3246

@droidmonkey droidmonkey added this to the v2.4.3 milestone Jun 9, 2019

@droidmonkey droidmonkey requested a review from phoerious Jun 9, 2019

Enable all entry keyboard shortcuts while in search
* Fixes #3034
* When the search text edit has focus, retain selected entry keyboard shortcuts and button pressing capability

@phoerious phoerious merged commit 6d449ac into release/2.4.3 Jun 11, 2019

3 checks passed

MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@phoerious phoerious deleted the hotfix/context-menu branch Jun 11, 2019

phoerious added a commit that referenced this pull request Jun 11, 2019

Release 2.4.3
- Fix library loading issues in the Snap and macOS releases [#3247]
- Fix various keyboard navigation issues [#3248]
- Fix main window toggling regression when clicking the tray icon on KDE [#3258]
- Add documentation for keyboard shortcuts to source code distribution [#3215]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.