Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed version information in AppImage #3283

Merged
merged 1 commit into from Jun 18, 2019

Conversation

3 participants
@TheAssassin
Copy link
Contributor

commented Jun 17, 2019

I've told some of your team members about that feature already, but it didn't make it into master yet, so I thought I'd show how it can be used.

appimagetool picks up a $VERSION environment variable and embeds that information into the AppImage in a way that allows desktop integration tools to display that in app launchers ("start menu" kind of things). That's really useful if you use more than one version, which might occur at updates, but is generally quite handy.

You could even get rid of the custom AppImage name picking, since appimagetool will also use $VERSION in the output filename, but that's for another day.

@droidmonkey droidmonkey changed the base branch from master to develop Jun 18, 2019

@droidmonkey droidmonkey added this to the v2.5.0 milestone Jun 18, 2019

@droidmonkey droidmonkey merged commit 0c2d1bc into keepassxreboot:develop Jun 18, 2019

4 checks passed

CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details

@TheAssassin TheAssassin deleted the TheAssassin:patch-1 branch Jun 18, 2019

@phoerious

This comment has been minimized.

Copy link
Member

commented Jun 18, 2019

I think the reason we define the AppImage name ourselves is consistency. At some point AppImages started putting the glibc version into the name which was both ugly and inconsistent as well as unexpected.

@TheAssassin

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

I think that was at the time when you were still using this functions.sh stuff. It's all good, I just wanted to mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.