Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building without features #3693

merged 1 commit into from Oct 30, 2019


Copy link

droidmonkey commented Oct 28, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (significant modification to existing code)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-code change)

Description and Context

  • Fix #3684 - CLI Yubikey is skipped when Yubikey feature is not enabled

  • Skip building testguibrowser if browser integration is disabled

I also added a "no feature" build in the Linux CI. Future issues when features are disabled will be caught within the CI process.

Testing strategy

Tested locally and with the new CI build.


  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
@droidmonkey droidmonkey added this to the v2.5.1 milestone Oct 28, 2019
@droidmonkey droidmonkey requested a review from phoerious Oct 28, 2019
tests/TestCli.cpp Outdated Show resolved Hide resolved
* Fix #3684 - Include YubiKey headers in CLI tests 

* Skip building testguibrowser if browser integration is disabled

* Cleanup test CMakeLists
@droidmonkey droidmonkey force-pushed the hotfix/no-feature-builds branch from 5f734dd to d13e79d Oct 29, 2019

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Oct 29, 2019

Ready for re-review


This comment has been minimized.

Copy link

louib commented Oct 29, 2019

@droidmonkey build failing on Windows:

TestCli::testClip() QTestLib: This test case check ("(((clipboard->text()) == (QString(""))))") failed because the requested timeout (1500 ms) was too short, 1550 ms would have been sufficient this time.

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Oct 29, 2019

Random anomoly

@droidmonkey droidmonkey merged commit 178bea6 into release/2.5.1 Oct 30, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Ubuntu Linux (KeepassXC) TeamCity build finished
Windows 10 (KeepassXC) TeamCity build finished
@droidmonkey droidmonkey deleted the hotfix/no-feature-builds branch Oct 30, 2019
phoerious added a commit that referenced this pull request Nov 11, 2019

- Add programmatic use of the EntrySearcher [#3760]
- Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824]
- macOS: Add ability to perform notarization of built package [#3827]


- Reduce file hash checking to every 30 seconds to correct performance issues [#3724]
- Correct formatting of notes in entry preview widget [#3727]
- Improve performance and UX of database statistics page [#3780]
- Improve interface for key file selection to discourage use of the database file [#3807]
- Hide Auto-Type sequences column when not needed [#3794]
- macOS: Revert back to using Carbon API for hotkey detection [#3794]
- CLI: Do not show protected fields by default [#3710]


- Secret Service: Correct issues interfacing with various applications [#3761]
- Fix building without additional features [#3693]
- Fix handling TOTP secret keys that require padding [#3764]
- Fix database unlock dialog password field focus [#3764]
- Correctly label open databases as locked on launch [#3764]
- Prevent infinite recursion when two databases AutoOpen each other [#3764]
- Browser: Fix incorrect matching of invalid URLs [#3759]
- Properly stylize the application name on Linux [#3775]
- Show application icon on Plasma Wayland sessions [#3777]
- macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.