Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: do not display protected fields by default. #3710

Merged

Conversation

@louib
Copy link
Member

louib commented Oct 28, 2019

Realized this might be a problem while using the interactive session with open.
Added an option to reveal the protected fields, but otherwise I'd say it's better not to display it by default.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-code change)

Testing strategy

existing and new unit tests.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
@louib louib added the plugin: CLI label Oct 28, 2019
@louib louib requested review from phoerious and droidmonkey Oct 28, 2019
@louib

This comment has been minimized.

Copy link
Member Author

louib commented Oct 28, 2019

Requires #3693 for the CI build to pass.

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Oct 29, 2019

Please rebase onto release/2.5.1 after #3593 is merged.

@droidmonkey droidmonkey added this to the v2.5.1 milestone Oct 29, 2019
@louib louib force-pushed the louib:cli_show_hide_protected branch from e6e89bc to 6921bd1 Oct 29, 2019
@louib louib changed the base branch from develop to release/2.5.1 Oct 29, 2019
@droidmonkey droidmonkey force-pushed the louib:cli_show_hide_protected branch from 6921bd1 to 1e84ace Oct 30, 2019
@droidmonkey droidmonkey merged commit f4d6b4d into keepassxreboot:release/2.5.1 Nov 2, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
phoerious added a commit that referenced this pull request Nov 11, 2019
Added

- Add programmatic use of the EntrySearcher [#3760]
- Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824]
- macOS: Add ability to perform notarization of built package [#3827]

Changed

- Reduce file hash checking to every 30 seconds to correct performance issues [#3724]
- Correct formatting of notes in entry preview widget [#3727]
- Improve performance and UX of database statistics page [#3780]
- Improve interface for key file selection to discourage use of the database file [#3807]
- Hide Auto-Type sequences column when not needed [#3794]
- macOS: Revert back to using Carbon API for hotkey detection [#3794]
- CLI: Do not show protected fields by default [#3710]

Fixed

- Secret Service: Correct issues interfacing with various applications [#3761]
- Fix building without additional features [#3693]
- Fix handling TOTP secret keys that require padding [#3764]
- Fix database unlock dialog password field focus [#3764]
- Correctly label open databases as locked on launch [#3764]
- Prevent infinite recursion when two databases AutoOpen each other [#3764]
- Browser: Fix incorrect matching of invalid URLs [#3759]
- Properly stylize the application name on Linux [#3775]
- Show application icon on Plasma Wayland sessions [#3777]
- macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.