Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show application icon in Plasma Wayland sessions #3777

Merged

Conversation

@elvisangelaccio
Copy link
Contributor

elvisangelaccio commented Nov 3, 2019

This is required to show the keepassxc icon on Wayland windows in a
Plasma Wayland session.

kwin_wayland fetches application icons from .desktop files and it
expects the desktop filename to be set on the QGuiApplication instance.

Without this, kwin sets a generic Wayland icon as fallback.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing strategy

Start keepassxc on a Plasma Wayland session with/without this patch and check its window icon.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
This is required to show the keepassxc icon on Wayland windows in a
Plasma Wayland session.

kwin_wayland fetches application icons from .desktop files and it
expects the desktop filename to be set on the QGuiApplication instance.

Without this, kwin sets a generic Wayland icon as fallback.
@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Nov 3, 2019

You can change the target branch. No need for a new PR.

@phoerious phoerious added this to the v2.5.1 milestone Nov 3, 2019
@elvisangelaccio

This comment has been minimized.

Copy link
Contributor Author

elvisangelaccio commented Nov 3, 2019

You can change the target branch. No need for a new PR.

I needed to change the source branch, though (since it was develop). I couldn't find a way to do that :/

@phoerious phoerious closed this Nov 3, 2019
@phoerious phoerious reopened this Nov 3, 2019
@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Nov 3, 2019

You rebase to the new branch, force-push and then change the branch you want to merge into at the top of the PR.

@phoerious phoerious merged commit 1722397 into keepassxreboot:release/2.5.1 Nov 3, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
scoroi added a commit to scoroi/keepassxc that referenced this pull request Nov 10, 2019
This is required to show the keepassxc icon on Wayland windows in a
Plasma Wayland session.

kwin_wayland fetches application icons from .desktop files and it
expects the desktop filename to be set on the QGuiApplication instance.

Without this, kwin sets a generic Wayland icon as fallback.
phoerious added a commit that referenced this pull request Nov 11, 2019
Added

- Add programmatic use of the EntrySearcher [#3760]
- Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824]
- macOS: Add ability to perform notarization of built package [#3827]

Changed

- Reduce file hash checking to every 30 seconds to correct performance issues [#3724]
- Correct formatting of notes in entry preview widget [#3727]
- Improve performance and UX of database statistics page [#3780]
- Improve interface for key file selection to discourage use of the database file [#3807]
- Hide Auto-Type sequences column when not needed [#3794]
- macOS: Revert back to using Carbon API for hotkey detection [#3794]
- CLI: Do not show protected fields by default [#3710]

Fixed

- Secret Service: Correct issues interfacing with various applications [#3761]
- Fix building without additional features [#3693]
- Fix handling TOTP secret keys that require padding [#3764]
- Fix database unlock dialog password field focus [#3764]
- Correctly label open databases as locked on launch [#3764]
- Prevent infinite recursion when two databases AutoOpen each other [#3764]
- Browser: Fix incorrect matching of invalid URLs [#3759]
- Properly stylize the application name on Linux [#3775]
- Show application icon on Plasma Wayland sessions [#3777]
- macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.