Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes to Auto-Type for 2.5.1 #3794

Merged
merged 3 commits into from Nov 9, 2019
Merged

Multiple fixes to Auto-Type for 2.5.1 #3794

merged 3 commits into from Nov 9, 2019

Conversation

@droidmonkey
Copy link
Member

droidmonkey commented Nov 5, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (significant modification to existing code)

Description and Context

  • Hide Auto-Type sequences column when unnecessary

    • Fix #3688 - hide the sequences column if all of the entry matches return the same sequence. This cleans up redundent data in the Auto-Type selection dialog introduced in 2.5.0.
  • Revert "Remove Carbon from Mac Auto-Type (#3347)"

    • Removing Carbon API was premature. The NSEvent API was causing shortcut capture issues due to it being a key monitor not an interceptor.
  • macOS: Check for Auto-Type permissions on use instead of at launch

    • Fix #3689 - link the use of Auto-Type with the permissions required to use it

NOTE: you can reset the screen recorder permissions using the following command: tccutil reset ScreenCapture

Screenshots

Dialog for entry-level Auto-Type:
image

Dialog for global Auto-Type:
image

Testing strategy

Tested on macOS 10.15

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
src/autotype/mac/AutoTypeMac.cpp Outdated Show resolved Hide resolved
src/autotype/mac/AutoTypeMac.cpp Show resolved Hide resolved
droidmonkey added 3 commits Nov 4, 2019
* Fix #3688 - hide the sequences column if all of the entry matches return the same sequence. This cleans up redundent data in the Auto-Type selection dialog introduced in 2.5.0.
* Fix #3689 - link the use of Auto-Type with the permissions required to use it
@droidmonkey droidmonkey force-pushed the hotfix/autotype branch from 4f34fd2 to 60c3a92 Nov 9, 2019
@weslly
weslly approved these changes Nov 9, 2019
@phoerious phoerious merged commit 7ba9fcc into release/2.5.1 Nov 9, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@phoerious phoerious deleted the hotfix/autotype branch Nov 9, 2019
phoerious added a commit that referenced this pull request Nov 11, 2019
Added

- Add programmatic use of the EntrySearcher [#3760]
- Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824]
- macOS: Add ability to perform notarization of built package [#3827]

Changed

- Reduce file hash checking to every 30 seconds to correct performance issues [#3724]
- Correct formatting of notes in entry preview widget [#3727]
- Improve performance and UX of database statistics page [#3780]
- Improve interface for key file selection to discourage use of the database file [#3807]
- Hide Auto-Type sequences column when not needed [#3794]
- macOS: Revert back to using Carbon API for hotkey detection [#3794]
- CLI: Do not show protected fields by default [#3710]

Fixed

- Secret Service: Correct issues interfacing with various applications [#3761]
- Fix building without additional features [#3693]
- Fix handling TOTP secret keys that require padding [#3764]
- Fix database unlock dialog password field focus [#3764]
- Correctly label open databases as locked on launch [#3764]
- Prevent infinite recursion when two databases AutoOpen each other [#3764]
- Browser: Fix incorrect matching of invalid URLs [#3759]
- Properly stylize the application name on Linux [#3775]
- Show application icon on Plasma Wayland sessions [#3777]
- macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
yan12125 added a commit to yan12125/keepassxc that referenced this pull request Nov 28, 2019
This commit reverts keepassxreboot#3357.

The previous PR is for the new symbol NSEventMaskKeyDown, which is
introduced in keepassxreboot#3347. In keepassxreboot#3794, keepassxreboot#3347 is reverted, so the workaround
in keepassxreboot#3357 is no longer needed. Furthermore, it causes build failures
on 10.11 (keepassxreboot#3932) as the header file for type NSEventMask is removed
in keepassxreboot#3794, too.

Note that this is not a complete fix. A complete patch can be found
at [1]. In MacPorts, the OS version for building a package is the same
as the OS that installs it, so #ifdef can be used to replace @available.
The latter language feature is not available until Xcode 9.

With the patch mentioned in the previous paragraph, KeePassXC 2.5.1
can be built on Mac OS X 10.9 or newer.

Ref: keepassxreboot#2899

[1] https://github.com/macports/macports-ports/blob/de1bb703ad19c258ad27eb903cf510dc1930107c/security/KeePassXC/files/patch-old-mac.diff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.