Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the purpose of the key file field clearer #3807

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@phoerious
Copy link
Member

phoerious commented Nov 6, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

The new unlock dialogue seems to confuse users as to what the purpose of the key file is. This
patch changes the generic "Select file..." affordance to the more explicit "Select key file (if any)..."
and prevents the user from using the KDBX file as a key file (since that would never work anyway).

The change breaks existing translations on purpose (instead of simply adjusting the en_US locale)
in order to force translators to update this string for their languages.

Resolves #3678

Testing strategy

Manual

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@phoerious phoerious added the ux label Nov 6, 2019
@phoerious phoerious added this to the v2.5.1 milestone Nov 6, 2019
@phoerious phoerious requested a review from keepassxreboot/core-developers Nov 6, 2019
Copy link
Member

droidmonkey left a comment

See Comment

src/gui/DatabaseOpenWidget.cpp Outdated Show resolved Hide resolved
@phoerious phoerious force-pushed the hotfix/3678-key-file-field branch 2 times, most recently from fc77426 to 19a6093 Nov 7, 2019
The new unlock dialogue seems to confuse users
as to what the purpose of the key file is. This
patch changes the generic "Select file..." affordance
to the more explicit "Select key file..." and adds
a help button to the label just like the one we
already have for the hardware key. Furthermore,
it prevents the user from using the KDBX file as its
own key file (since that would never work anyway).

The change breaks existing translations on purpose
(instead of simply adjusting the en_US locale)
in order to force translators to update this string
for their languages.

Resolves #3678
@phoerious phoerious force-pushed the hotfix/3678-key-file-field branch from 19a6093 to 627b2f2 Nov 7, 2019
@droidmonkey droidmonkey merged commit 5d2766e into release/2.5.1 Nov 8, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@droidmonkey droidmonkey deleted the hotfix/3678-key-file-field branch Nov 8, 2019
phoerious added a commit that referenced this pull request Nov 11, 2019
Added

- Add programmatic use of the EntrySearcher [#3760]
- Explicitly clear database memory upon locking even if the object is not deleted immediately [#3824]
- macOS: Add ability to perform notarization of built package [#3827]

Changed

- Reduce file hash checking to every 30 seconds to correct performance issues [#3724]
- Correct formatting of notes in entry preview widget [#3727]
- Improve performance and UX of database statistics page [#3780]
- Improve interface for key file selection to discourage use of the database file [#3807]
- Hide Auto-Type sequences column when not needed [#3794]
- macOS: Revert back to using Carbon API for hotkey detection [#3794]
- CLI: Do not show protected fields by default [#3710]

Fixed

- Secret Service: Correct issues interfacing with various applications [#3761]
- Fix building without additional features [#3693]
- Fix handling TOTP secret keys that require padding [#3764]
- Fix database unlock dialog password field focus [#3764]
- Correctly label open databases as locked on launch [#3764]
- Prevent infinite recursion when two databases AutoOpen each other [#3764]
- Browser: Fix incorrect matching of invalid URLs [#3759]
- Properly stylize the application name on Linux [#3775]
- Show application icon on Plasma Wayland sessions [#3777]
- macOS: Check for Auto-Type permissions on use instead of at launch [#3794]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.