Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to hide a protected attribute after reveal #3877

Merged

Conversation

@ba32107
Copy link
Contributor

ba32107 commented Nov 16, 2019

Fixes #1750

Type of change

  • New feature (non-breaking change which adds functionality)

Description and Context

  • Added extra functionality to re-hide the attribute
  • I have ran make format, which changed a lot of unrelated files - I can revert those changes if preferred
  • Did not change "Protect" to "Mark as Hidden", because then we'd need to change the concept of "protected" accross the whole code base, and I didn't think it was worth it.

Screenshots

image
image

Testing strategy

  • Manual testing

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@ba32107 ba32107 marked this pull request as ready for review Nov 16, 2019
@droidmonkey droidmonkey added this to the v2.5.2 milestone Nov 18, 2019
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Nov 18, 2019

Please rebase onto release/2.5.2 and split your actual changes from the make format into two commits.

@droidmonkey droidmonkey self-requested a review Nov 18, 2019
@ba32107 ba32107 force-pushed the ba32107:feature/reveal_prot_attr branch from d474c88 to ac6ed0d Nov 18, 2019
@ba32107

This comment has been minimized.

Copy link
Contributor Author

ba32107 commented Nov 18, 2019

Done - I don't know why src/cli/Analyze.cpp conflicts though.

Oh, or did you mean create a new PR to target release/2.5.2?

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Nov 18, 2019

I can move this over to 2.5.2

@droidmonkey droidmonkey force-pushed the ba32107:feature/reveal_prot_attr branch from ac6ed0d to 88bee48 Nov 18, 2019
@droidmonkey droidmonkey changed the base branch from develop to release/2.5.2 Nov 18, 2019
@droidmonkey droidmonkey force-pushed the ba32107:feature/reveal_prot_attr branch from 88bee48 to 6aff51f Nov 18, 2019
@droidmonkey droidmonkey force-pushed the ba32107:feature/reveal_prot_attr branch from 6aff51f to 1ff397f Nov 23, 2019
@droidmonkey droidmonkey force-pushed the ba32107:feature/reveal_prot_attr branch from 1ff397f to dec566b Nov 23, 2019
@droidmonkey droidmonkey merged commit 9363123 into keepassxreboot:release/2.5.2 Nov 23, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@ba32107 ba32107 deleted the ba32107:feature/reveal_prot_attr branch Nov 23, 2019
droidmonkey added a commit that referenced this pull request Jan 4, 2020
Added

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]

Changed

- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]

Fixed

- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.