Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DB open form while loading DB #3885

Merged

Conversation

@ba32107
Copy link
Contributor

ba32107 commented Nov 17, 2019

Disable the DB open form while loading the DB to prevent multiple Enter/OK button events

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

Fixes #3872

Testing strategy

  • Manual testing

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@ba32107

This comment has been minimized.

Copy link
Contributor Author

ba32107 commented Nov 17, 2019

Added another commit to process all UI events before opening the DB. With this commit, my comment actually reflects reality:
#3742 (comment)

@ba32107

This comment has been minimized.

Copy link
Contributor Author

ba32107 commented Nov 17, 2019

On a separate, unrelated note: I noticed that my 2nd commit didn't dismiss the PR approval. I think it's good practice to enable it on the repo - is there a particular reason it's not?

@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Nov 17, 2019

Didn't realize that was an option.

@droidmonkey droidmonkey added this to the v2.5.2 milestone Nov 18, 2019
@droidmonkey droidmonkey force-pushed the ba32107:hotfix/enter_twice_crash branch from cfea8f0 to 2afbf9d Nov 18, 2019
@droidmonkey droidmonkey changed the base branch from develop to release/2.5.2 Nov 18, 2019
@droidmonkey droidmonkey force-pushed the ba32107:hotfix/enter_twice_crash branch from 2afbf9d to b21ac4b Nov 23, 2019
@droidmonkey droidmonkey merged commit 6c65b48 into keepassxreboot:release/2.5.2 Nov 23, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@ba32107 ba32107 deleted the ba32107:hotfix/enter_twice_crash branch Nov 23, 2019
droidmonkey added a commit that referenced this pull request Jan 4, 2020
Added

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]

Changed

- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]

Fixed

- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.