Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FdoSecrets: handle the exposed group being moved to recycle bin #3914

merged 1 commit into from Nov 29, 2019


Copy link

Aetf commented Nov 22, 2019

Fix #3861

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

When the exposed group was moved to the recycle bin, it is still incorrectly exposed to DBus. While there are some checks in place skipping entries/groups in the recycle bin, they are not thorough, thus causing the crash in #3861.

Testing strategy

Tested manually.

PS: I'm thinking about what is the best way to write unit tests for FdoSecrets. Currently, the service requires DatabaseTabWidget, and can't be tested without bringing up the full app. I'd appreciate any advice on how to avoid that. Or probably it's ok to just run it as GUI test?


  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@Aetf Aetf changed the base branch from develop to release/2.5.2 Nov 22, 2019
@droidmonkey droidmonkey added this to the v2.5.2 milestone Nov 23, 2019
@droidmonkey droidmonkey force-pushed the Aetf:fdo-secrets-3861 branch from 186d8c6 to 0a4d1c8 Nov 23, 2019
@droidmonkey droidmonkey merged commit 6dd9702 into keepassxreboot:release/2.5.2 Nov 29, 2019
3 checks passed
3 checks passed
MacOS (KeepassXC) TeamCity build finished
Ubuntu Linux (KeepassXC) TeamCity build finished
Windows 10 (KeepassXC) TeamCity build finished
@Aetf Aetf deleted the Aetf:fdo-secrets-3861 branch Dec 3, 2019
droidmonkey added a commit that referenced this pull request Jan 4, 2020

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]


- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]


- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.