Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use entry only for HTTP Basic Auth #3927

Conversation

@varjolintu
Copy link
Member

varjolintu commented Nov 24, 2019

Type of change

  • New feature (non-breaking change which adds functionality)

Description and Context

Adds a new option to use entry only with HTTP Basic Auth. If an entry uses additional URL's, the option will be enabled for them also.

Fixes #3925.

Screenshots

Screen Shot 2019-11-24 at 18 01 02

Testing strategy

Manually.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
Copy link
Member

droidmonkey left a comment

If there are two entries for a webpage, one of them has this setting, is the following true:

  1. Login form only shows the entry that does NOT have this setting
  2. HTTP Auth form shows BOTH entries
src/gui/entry/EditEntryWidget.cpp Outdated Show resolved Hide resolved
src/gui/entry/EditEntryWidgetBrowser.ui Show resolved Hide resolved
@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Nov 29, 2019

If there are two entries for a webpage, one of them has this setting, is the following true:

1. Login form only shows the entry that does NOT have this setting

2. HTTP Auth form shows BOTH entries
  1. Both entries are showed with HTTP Auth form. Only one with the normal login form.
@droidmonkey

This comment has been minimized.

Copy link
Member

droidmonkey commented Nov 29, 2019

Is that the desired behavior? Or should be only show the ones marked explicitly for http auth (if any are marked as such).

@varjolintu

This comment has been minimized.

Copy link
Member Author

varjolintu commented Nov 29, 2019

@droidmonkey Yes. The whole idea was to hide entries from other than HTTP Basic Auth. This is also easy to test if you add the option to an entry and add an Additional URL to some other site.

@varjolintu varjolintu force-pushed the varjolintu:feature/entry_option_only_http_auth branch from c0e27fb to 8a95fb0 Dec 6, 2019
@droidmonkey droidmonkey force-pushed the varjolintu:feature/entry_option_only_http_auth branch from 8a95fb0 to f933529 Dec 21, 2019
@droidmonkey droidmonkey force-pushed the varjolintu:feature/entry_option_only_http_auth branch from f933529 to dd6b809 Dec 21, 2019
@droidmonkey droidmonkey merged commit c0796d8 into keepassxreboot:release/2.5.2 Dec 21, 2019
4 checks passed
4 checks passed
Code Format (KeepassXC) TeamCity build finished
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@varjolintu varjolintu deleted the varjolintu:feature/entry_option_only_http_auth branch Dec 22, 2019
droidmonkey added a commit that referenced this pull request Jan 4, 2020
Added

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]

Changed

- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]

Fixed

- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.