Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last round of fixes for 2.5.2 #4075

Merged
merged 7 commits into from Jan 3, 2020
Merged

Last round of fixes for 2.5.2 #4075

merged 7 commits into from Jan 3, 2020

Conversation

@droidmonkey
Copy link
Member

droidmonkey commented Dec 31, 2019

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

Last bit of 2.5.2 bug fixes:

  • Fix compiler issues with Qt 5.14

    • Remove deprecation warnings when not doing a DEV_BUILD. Qt 5.14 introduced several deprecation flags on basic function calls in QList and QSet that would require several #pragma ignores. Assuming this was in preparation to Qt 6.0.
    • Remove unnecessary assert in PasswordEditWidget that was hit in macOS debug builds.
  • Choose a better monospace font on macOS (Fixes #1917)

  • Hide snap browser warning label on non-Linux OS (Fixes #3707)

  • Fix AutoOpen with key file only databases (Fixes #3931)

  • Use new TOTP structure when importing 1Password Vault (Fixes #3999)

  • Fix TOTP Dialog not closing on lock

  • Improve GUI test reliability

    • Explicitly resize the window to improve testing on High DPI displays
    • Add additional bootstrap calls to mimic the actual application

Testing strategy

Ran all tests locally and on macOS

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
droidmonkey added 7 commits Dec 30, 2019
* Remove deprecation warnings when not doing a DEV_BUILD. Qt 5.14 introduced several deprecation flags on basic function calls in QList and QSet that would require several #pragma ignores. Assuming this was in preparation to Qt 6.0.

* Remove unnecessary assert in PasswordEditWidget that was hit in macOS debug builds.
* Explicitly resize the window to improve testing on High DPI displays
* Add additional bootstrap calls to mimic the actual application
@droidmonkey droidmonkey added the bug label Dec 31, 2019
@droidmonkey droidmonkey added this to the v2.5.2 milestone Dec 31, 2019
@droidmonkey droidmonkey requested a review from phoerious Dec 31, 2019
@droidmonkey droidmonkey changed the title Hotfix/last 252 Last round of fixes for 2.5.2 Dec 31, 2019
tests/gui/TestGui.cpp Show resolved Hide resolved
@droidmonkey droidmonkey merged commit 7ad330e into release/2.5.2 Jan 3, 2020
5 checks passed
5 checks passed
Code Format (KeepassXC) TeamCity build finished
Details
CodeFactor No issues found.
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@droidmonkey droidmonkey deleted the hotfix/last-252 branch Jan 3, 2020
droidmonkey added a commit that referenced this pull request Jan 4, 2020
Added

- Browser: Show UI warning when entering invalid URLs [#3912]
- Browser: Option to use an entry only for HTTP auth [#3927]

Changed

- Disable the user interface when merging or saving the database [#3991]
- Ability to hide protected attribute after reveal [#3877]
- Remove mention of "snaps" in Windows and macOS [#3879]
- CLI: Merge parameter for source database key file (--key-file-from) [#3961]
- Improve GUI tests reliability on Hi-DPI displays [#4075]
- Disable deprecation warnings to allow building with Qt 5.14+ [#4075]
- OPVault: Use 'otp' attribute for TOTP field imports [#4075]

Fixed

- Fix crashes when saving a database to cloud storage [#3991]
- Fix crash when pressing enter twice while opening database [#3885]
- Fix handling of HTML when displayed in the entry preview panel [#3910]
- Fix start minimized to tray on Linux [#3899]
- Fix Auto Open with key file only databases [#4075]
- Fix escape key closing the standalone password generator [#3892]
- macOS: Fix monospace font usage in password field and notes [#4075]
- macOS: Fix building on macOS 10.9 to 10.11 [#3946]
- Fix TOTP setup dialog not closing on database lock [#4075]
- Browser: Fix condition where additional URLs are ignored [#4033]
- Browser: Fix subdomain matching to return only relevant site entries [#3854]
- Secret Service: Fix multiple crashes and incompatibilities [#3871, #4009, #4074]
- Secret Service: Fix searching of entries [#4008, #4036]
- Secret Service: Fix behavior when exposed group is recycled [#3914]
- CLI: Release the database instance before exiting interactive mode [#3889]
- Fix (most) memory leaks in tests [#3922]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.