Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty path to URL when needed #4134

Merged

Conversation

@varjolintu
Copy link
Member

varjolintu commented Jan 8, 2020

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

Add's an empty path to URL's when needed. Otherwise URL's https://example.com and https://example.com/ will have a different sorting priority which causes the latter one to be choosed when "Return only best-matching credentials" is enabled.

Fixes #4109.

Testing strategy

Manually.

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
@varjolintu varjolintu added this to the v2.6.0 milestone Jan 8, 2020
@varjolintu varjolintu requested a review from droidmonkey Jan 8, 2020
@varjolintu varjolintu modified the milestones: v2.6.0, v2.5.3 Jan 11, 2020
@varjolintu varjolintu changed the base branch from develop to release/2.5.3 Jan 11, 2020
@varjolintu varjolintu force-pushed the varjolintu:fix/add_path_to_url branch from afa933f to 6decc99 Jan 11, 2020
@droidmonkey droidmonkey merged commit 4607320 into keepassxreboot:release/2.5.3 Jan 12, 2020
4 checks passed
4 checks passed
Code Format (KeepassXC) TeamCity build finished
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
phoerious added a commit that referenced this pull request Jan 19, 2020
Fixed

- Fix a possible database lockout when removing a YubiKey from a KDBX 3.1 database [#4147]
- Fix crash if Auto-Type is performed on a new entry [#4150]
- Fix crash when all entries are deleted from a group [#4156]
- Improve the reliability of clipboard clearing on Gnome [#4165]
- Do not check cmd:// URLs for valid URL syntax anymore [#4172]
- Prevent unnecessary merges for databases on network shares [#4153]
- Browser: Prevent native messaging proxy from blocking application shutdown [#4155]
- Browser: Improve website URL matching [#4134, #4177]

Added

- Browser: Enable support for Chromium-based Edge Browser [#3359]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.