Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Prevent crash if Auto-Type performed on new entry #4150

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@phoerious
Copy link
Member

phoerious commented Jan 10, 2020

Backport of #4132.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Check that entry's group is not nullptr
  • Fixes #3967

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
* Check that entry's group is not nullptr
* Fixes #3967
@phoerious phoerious added this to the v2.5.3 milestone Jan 10, 2020
@phoerious phoerious requested a review from keepassxreboot/core-developers Jan 10, 2020
@phoerious phoerious changed the title Prevent crash if Auto-Type performed on new entry Prevent crash if Auto-Type performed on new entry (backport) Jan 10, 2020
@phoerious phoerious changed the title Prevent crash if Auto-Type performed on new entry (backport) Backport: Prevent crash if Auto-Type performed on new entry Jan 10, 2020
@phoerious phoerious added the backport label Jan 10, 2020
@phoerious phoerious merged commit 39a7ce5 into release/2.5.3 Jan 10, 2020
4 checks passed
4 checks passed
Code Format (KeepassXC) TeamCity build finished
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@phoerious phoerious deleted the hotfix/group-check-crash-backport branch Jan 10, 2020
phoerious added a commit that referenced this pull request Jan 19, 2020
Fixed

- Fix a possible database lockout when removing a YubiKey from a KDBX 3.1 database [#4147]
- Fix crash if Auto-Type is performed on a new entry [#4150]
- Fix crash when all entries are deleted from a group [#4156]
- Improve the reliability of clipboard clearing on Gnome [#4165]
- Do not check cmd:// URLs for valid URL syntax anymore [#4172]
- Prevent unnecessary merges for databases on network shares [#4153]
- Browser: Prevent native messaging proxy from blocking application shutdown [#4155]
- Browser: Improve website URL matching [#4134, #4177]

Added

- Browser: Enable support for Chromium-based Edge Browser [#3359]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.